Fix emotesets not loading properly #2905
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fk I'm so tired...
fourtf
reviewed
Jun 21, 2021
removed all silly debug stuff
talneoran
approved these changes
Jun 21, 2021
There was a problem hiding this comment.
Seems to work 👍
Only issue is the qa_TW_Partner user that twitch seems to use for some of the global emotes, which causes them to show under that user instead of under Twitch in the emote popup.
Could maybe handle this by manually moving emotes from that emote set to the Twitch set until this is changed by twitch or another fix is possible.
Mm2PL
reviewed
Jun 21, 2021
zneix
added a commit
to SevenTV/chatterino7
that referenced
this pull request
Jun 25, 2021
Now we're on commit 0021290; Changes from upstream we pulled: - Bugfix: Fix reconnecting when IRC write connection is lost (Chatterino#1831, Chatterino#2356, Chatterino#2850, Chatterino#2892) - Bugfix: Fixed subscription emotes showing up incorrectly in the emote menu. (Chatterino#2905) Changes added in Chatterino7 only: - Major: Added 7tv badges. (2154981) - Minor: Fixed potential issues preventing 7tv emotes from loading (c0b1117)
This was referenced May 16, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull request checklist:
CHANGELOG.mdwas updated, if applicableDescription
Fixes #2904