Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add /openurl command #2926

Merged
merged 8 commits into from Jun 27, 2021
Merged

Add /openurl command #2926

merged 8 commits into from Jun 27, 2021

Conversation

talneoran
Copy link
Contributor

@talneoran talneoran commented Jun 26, 2021

Pull request checklist:

  • CHANGELOG.md was updated, if applicable

Description

Add a /openurl <URL> built-in command that allows opening URLs through chat.
This is mostly useful for usage in custom commands, for example a command /report with the definition /openurl twitch.tv/{1}/report can be used to open the user report page of the user given as the first argument.

Closes #2461.

@Mm2PL Mm2PL self-requested a review June 26, 2021 20:38
Copy link
Collaborator

@Mm2PL Mm2PL left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works as expected except the comment I made.

src/controllers/commands/CommandController.cpp Outdated Show resolved Hide resolved
@pajlada pajlada requested review from zneix and Mm2PL June 27, 2021 11:22
Copy link
Collaborator

@Mm2PL Mm2PL left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@zneix zneix enabled auto-merge (squash) June 27, 2021 11:28
@zneix zneix merged commit 991892e into Chatterino:master Jun 27, 2021
@talneoran talneoran deleted the openurl-command branch June 27, 2021 12:06
zneix added a commit to SevenTV/chatterino7 that referenced this pull request Jun 28, 2021
Now we're on commit 6355742; Changes from upstream we pulled:

- Minor: Channel name in `<channel> has gone offline. Exiting host mode.` messages is now clickable. (Chatterino#2922)
- Minor: Added `/openurl` command. Usage: `/openurl <URL>`. Opens the provided URL in the browser. (Chatterino#2461, Chatterino#2926)
- Bugfix: Fixed large timeout durations in moderation buttons overlapping with usernames or other buttons. (Chatterino#2865, Chatterino#2921)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add support for opening links from chat commands
4 participants