fix: provide better UX for HTML color picker edit #2942
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Before this change, it was checked whether the text of the HTML color picker line edit represents a valid color. Since the HTML color syntax allows the format `#RGB` (see [1]), this lead to the lambda setting the color edit to the full format string (`#RRGGBB`) whenever three characters have been entered. Due to the QValidator set up for the line edit, attempts to change the text again would be rejected. With this change, validity of the color is only checked when the `QLineEdit::editingFinished` signal is emitted. (At the time of writing, this corresponds to "Return" being pressed or a focus loss of the line edit.) Since the signal is only emitted when the validator approves the input (see [2] for more information), this will never lead to the color picker being in an inconsistent state. [1]: https://developer.mozilla.org/en-US/docs/Web/CSS/color_value#syntax_2 [2]: https://doc.qt.io/qt-5/qlineedit.html#editingFinished
zneix
approved these changes
Jul 2, 2021
Mm2PL
approved these changes
Jul 2, 2021
zneix
added a commit
to SevenTV/chatterino7
that referenced
this pull request
Jul 5, 2021
Now we're on commit cc9d44a; Changes from upstream we pulled: - Minor: Username in channel points rewards redemption messages is now clickable. (Chatterino#2673, Chatterino#2953) - Bugfix: Now deleting cache files that weren't modified in the past 14 days. (Chatterino#2947) - Bugfix: Middle mouse click no longer scrolls in not fully populated usercards and splits. (Chatterino#2933) - Bugfix: Fix bad behavior of the HTML color picker edit when user input is being entered. (Chatterino#2942)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull request checklist:
CHANGELOG.mdwas updated, if applicableDescription
Fixes #2939. See there and the commit message for additional context.
Original commit message: