New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Separate Ubuntu .deb packages per Ubuntu release #4357
Conversation
/home/runner/work/chatterino2 was included in the .deb file
Added Logs. I changed it on master accidently
I added the move directory up, because else the paths would look like e. g. /home/runner/work/chatterino2/chatterino2/build/appdir/usr/share/applications/com.chatterino.chatterino.desktop
Took the dependency names from Chatterino#4212
Might glide out of sync with CI
This is required for Ubuntu 20.04 deb packages to work
@Wissididom I made some changes to this branch now where there are two Artifacts built: Chatterino-ubuntu-20.04.deb and Chatterino-ubuntu-22.04.deb - both work on fresh installations for me (the Can you give these a try to ensure they work as expected for you? |
Will look into when I'm back at the PC (I'm currently at my grandparents diamond wedding) |
On my system, universe seemed to have been pre-enabled by default. First, I tested installing the wrong package for the wrong version of Ubuntu, so there will be 2 fails as expected parts in this comment. All of them were installed through the command Installing 22.04 on Ubuntu 20.04 fails as expected:
Installing 20.04 on Ubuntu 20.04 succeeds as expected:
Running Chatterino on Ubuntu 20.04 works as expected
Installing 20.04 on Ubuntu 22.04 fails as expected:
Installing 22.04 on Ubuntu 22.04 succeeds as expected:
Running Chatterino on Ubuntu 22.04 works as expected
Maybe also add qt5-image-formats-plugins because I noticed it being suggested while installing both versions, and I've heard that it might be involved in some Emote things, but I'm not sure if that is even a problem? Could test if I knew which emotes needed it. Other than that I'm pretty happy with this PR and also that the deb is not > 100 MB anymore (thanks pajlada) |
7TV animated emotes |
Pull request checklist:
CHANGELOG.md
was updated, if applicableDescription
The main problem was, that chatterino was installed to
/home/runner/chatterino2/chatterino2/package/home/runner/chatterino2/chatterino2/appdir/usr/bin/chatterino
on the destination systemAfter I've fixed that, I got dependency problems that I wasn't able to fix just by specifying them, so I bundled all of the Qt folder
After that there just was open to set the LD_LIBRARY_PATH, which I wanted to do in the postinst script which I didn't get to work, which is why I later went another way.
After that I've tried to just include the necessary files from the Qt folder like libQt5Network, libQt5Core, libQt5Gui etc., but with that approach I had other library dependency problems (in this case with libicui.so.58) which is why I changed it back to bundle all files again
Then I tried specifying the files that were installed in jurplel/install-qt-action which didn't change anything.
Now in this version I've moved chatterino and everything a few folders up and specified the LD_LIBRARY_PATH environment variable inside the .desktop file.
Now Chatterino opens up without problems but haven't gotten to test anything else apart from opening it yet.
I'm not sure if I should make a Dev entry in the Changelog, so I leave editing the Changelog out for now.
Here is a video of me installing Chatterino in a VM and running it with the latest build from my fork: https://www.youtube.com/watch?v=Z79Ww1oVUOo
I was too lazy to edit the video, so I just did
ffmpeg -i input.mkv -an output.mp4
.