Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add new Helix scope for managing raids #42

Closed
pajlada opened this issue Jun 9, 2022 · 6 comments · Fixed by #44
Closed

Add new Helix scope for managing raids #42

pajlada opened this issue Jun 9, 2022 · 6 comments · Fixed by #44
Labels
good first issue Good for newcomers

Comments

@pajlada
Copy link
Member

pajlada commented Jun 9, 2022

New raids API endpoints are available in Helix, we will most likely want to use one or both of them https://discuss.dev.twitch.tv/t/new-raids-api-endpoints-are-now-in-open-beta/38866

For this to be possible, we'll need to add the channel:manage:raids scope to the client login page.

File(s) to edit

  • pages/client_login.js

How to test

Log in with your account on the client_login page, use the client id + oauth token and make a request to the https://dev.twitch.tv/docs/api/reference#start-a-raid and https://dev.twitch.tv/docs/api/reference#cancel-a-raid endpoints and ensure that the requests are allowed as expected. Note that your stream will need to be live when testing.

@pajlada pajlada added the good first issue Good for newcomers label Jun 9, 2022
@iProdigy
Copy link
Contributor

iProdigy commented Jun 9, 2022

Given raid/unraid already exist over irc & new helix endpoints don't work for channel editors (like irc does), we can prolly skip helix for this until improvements are made

@zneix
Copy link
Contributor

zneix commented Jun 9, 2022

Given raid/unraid already exist over irc & new helix endpoints don't work for channel editors (like irc does), we can prolly skip helix for this until improvements are made

I agree. However cancelling raids is something that might be a nice touch. While it'd only work for broadcaster, not editors, it could still be a nice touch so the scope is worth implementing imo.

@Mm2PL
Copy link
Contributor

Mm2PL commented Jun 9, 2022

I think we're wrong, IRC actually has a command for cancelling a raid:

> /help raid
< Usage: "/raid <channel>" - Raid another channel. Use "/unraid" to cancel the Raid. 
> /help unraid
< Usage: "/unraid" - Cancel the Raid. 

@zneix
Copy link
Contributor

zneix commented Jun 9, 2022

Oops. My bad, nevermind my previous comment. Let's wait then, as suggested by Prodigy.

@iProdigy
Copy link
Contributor

iProdigy commented Jun 9, 2022

I think we're wrong, IRC actually has a command for cancelling a raid:

correct; tho since /unraid is slightly obscure, c2 could add/document a /cancelraid alias (tho this belongs on a separate issue tracker)

@pajlada
Copy link
Member Author

pajlada commented Jun 9, 2022

I don't think we should wait with requesting the scope from users if it's a feature we could see ourselves using in the future

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants