From eae4ddba83886c27f8be88511c02e9d780a7da00 Mon Sep 17 00:00:00 2001 From: Faye Date: Thu, 26 Mar 2020 10:40:15 +0100 Subject: [PATCH 1/2] Add the guideline on closing a PR Added the guideline on closing a PR when it has been inactive for at least 14 days --- CONTRIBUTING.md | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/CONTRIBUTING.md b/CONTRIBUTING.md index 4ab19b829bf..8ca99ab5733 100644 --- a/CONTRIBUTING.md +++ b/CONTRIBUTING.md @@ -46,6 +46,8 @@ this: 3. **Commit** changes to your own feature branch 4. **Push** your work back up to your forked repository 5. Submit a **Pull request** (PR) so that we can review your changes + + ⚠ Pull requests without any activity for at least 14 days will be closed. To avoid this, please reply when asked for more information or update your PR in case in didn't meet the requirements (e.g. failed checks). If it’s your first time to contribute to an open source project, we recommend reading [this guide](https://opensource.guide/how-to-contribute/). You may also want to try the [GitHub Hello World tutorial](https://guides.github.com/activities/hello-world/). @@ -212,7 +214,7 @@ The public repository of [Checkmk](https://github.com/tribe29/checkmk) is integrated with Travis CI. Each time a Pull request is submitted, Travis will have a look at the changes. -**Important:** We only review PRs that are confirmed to be OK by Travis. +**⚠ Important:** We only review PRs that are confirmed to be OK by Travis. If a check failed, please fix it and update the PR. PRs will be closed after at least 14 days of inactivity. It is recommended to run all tests locally before submitting a PR. If you want to execute the full test suite, you can do this by executing these commands in From 14c7c2924d41492d176fade01372e4a713766a2d Mon Sep 17 00:00:00 2001 From: Faye Date: Tue, 31 Mar 2020 11:15:47 +0200 Subject: [PATCH 2/2] Edit the PR guideline based on comments -Formatted the guidelines to be <100 characters per line. -Clarified that it concerns cases where the author didn't respond. --- CONTRIBUTING.md | 8 ++++++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/CONTRIBUTING.md b/CONTRIBUTING.md index 8ca99ab5733..2a720094f42 100644 --- a/CONTRIBUTING.md +++ b/CONTRIBUTING.md @@ -47,7 +47,9 @@ this: 4. **Push** your work back up to your forked repository 5. Submit a **Pull request** (PR) so that we can review your changes - ⚠ Pull requests without any activity for at least 14 days will be closed. To avoid this, please reply when asked for more information or update your PR in case in didn't meet the requirements (e.g. failed checks). + ⚠ Please reply when asked for more information or to update your PR +in case in didn't meet the requirements (e.g. failed checks). +If there's no response from the author for at least 14 days, the PR will be closed. If it’s your first time to contribute to an open source project, we recommend reading [this guide](https://opensource.guide/how-to-contribute/). You may also want to try the [GitHub Hello World tutorial](https://guides.github.com/activities/hello-world/). @@ -214,7 +216,9 @@ The public repository of [Checkmk](https://github.com/tribe29/checkmk) is integrated with Travis CI. Each time a Pull request is submitted, Travis will have a look at the changes. -**⚠ Important:** We only review PRs that are confirmed to be OK by Travis. If a check failed, please fix it and update the PR. PRs will be closed after at least 14 days of inactivity. +**⚠ Important:** We only review PRs that are confirmed to be OK by Travis. +If a check failed, please fix it and update the PR. +PRs will be closed if the author didn't respond for at least 14 days. It is recommended to run all tests locally before submitting a PR. If you want to execute the full test suite, you can do this by executing these commands in