Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use relative imports #46

Merged
merged 1 commit into from Aug 28, 2021
Merged

Conversation

CendioOssman
Copy link
Contributor

This makes it possible to embed Cheetah in other packages without risking conflict with other versions.

@phdru
Copy link
Member

phdru commented Jul 25, 2021

Thank you! There is a minor failing flake8 test under Python 2.7. See https://app.travis-ci.com/github/CheetahTemplate3/cheetah3/jobs/525956382. Can you please fix it?

My advice is to make the code like this:

package = __spec__.parent  # noqa: F821 undefined name '__spec__'

Please run all tests locally. Running tox is the simplest way.

This makes it possible to embed Cheetah in other packages without
risking conflict with other versions.
@CendioOssman
Copy link
Contributor Author

Sorry for the delay. I just got back from vacation.

Pushed a new version with a noqa for that line. Should hopefully make flake8 happier. It passes here locally now at least.

@phdru phdru merged commit 88cccc4 into CheetahTemplate3:master Aug 28, 2021
@phdru
Copy link
Member

phdru commented Aug 28, 2021

Merged. Thank you very much!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants