Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to Gradle 7.2 #27

Merged
merged 2 commits into from
Oct 18, 2021
Merged

Update to Gradle 7.2 #27

merged 2 commits into from
Oct 18, 2021

Conversation

ROMVoid95
Copy link

@ROMVoid95 ROMVoid95 commented Sep 13, 2021

Pull Request

Pull Request Checklist

Please follow the following steps before opening this PR.

PRs that do not complete the checklist will be subject to denial for
missing information.

Pull Request Information

Check and fill in the blanks for all that apply:

  • My PR fixes a bug, error, or other issue with the library's codebase.
  • My PR is for the ______ module of the JDA-Utilities library.
  • My PR creates a new module for the JDA-Utilities library: ______.

Description

Updated Gradle to 7.2 - A test with a local bot instance was done. All subprojects ran successful builds and everything in the bot worked as well.

@Chew Chew linked an issue Sep 13, 2021 that may be closed by this pull request
3 tasks
@Chew
Copy link
Owner

Chew commented Sep 13, 2021

That easy, huh. Will give it a spin locally to see. Looks like it compiles correctly on Actions which is always a good sign 😄

@ROMVoid95
Copy link
Author

I was quite surprised myself, 7.2 has seemed to be a much easier version for updating. Thankfully the project never implemented its own Groovy classes for building. Which is where I've ran into major pains when updating projects.

@Chew
Copy link
Owner

Chew commented Sep 22, 2021

Sorry for the delay!

Was able to deploy a test, 1.22.1-SNAPSHOT, to my repo.

Can try testing with this for a bit to make sure all is well but I'd bet it is.

@ROMVoid95
Copy link
Author

No problem, just ran a test on a bot using the shapshot, have not ran into any issues. Thanks for the update

@ROMVoid95
Copy link
Author

Also wanted to check, since this is a version update PR, what's your opinion on updating the JDA dependency version to use 4.3.0+? or at least updating the latest build and updating depreciated methods in the Command subproject.

@Chew
Copy link
Owner

Chew commented Sep 23, 2021

We already use 4.3.0 per https://github.com/Chew/JDA-Chewtils/blob/master/build.gradle#L39

I suppose I could fix the deprecations since it's up to date now, but out of the scope of this PR.

Forgot to push these, had been sitting on local repo.
@Chew Chew merged commit 2435212 into Chew:master Oct 18, 2021
@ROMVoid95 ROMVoid95 deleted the gradle7 branch October 18, 2021 21:43
@Chew Chew added this to the 1.23.0 milestone Oct 31, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Please use latest gradle/jda version
3 participants