Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't farm compressed plots if context count is 0 #16004

Merged
merged 2 commits into from
Aug 11, 2023
Merged

Don't farm compressed plots if context count is 0 #16004

merged 2 commits into from
Aug 11, 2023

Conversation

fchirica
Copy link
Contributor

Purpose:

Current Behavior:

New Behavior:

Testing Notes:

@fchirica fchirica requested a review from a team as a code owner August 10, 2023 17:54
@fchirica fchirica added the Fixed Required label for PR that categorizes merge commit message as "Fixed" for changelog label Aug 10, 2023
@wallentx wallentx linked an issue Aug 10, 2023 that may be closed by this pull request
[Bug] 2.0.0-rc3 silently stops sending partials to a pool after a few minutes if a compressed plot is present #15949
Closed
@fchirica fchirica mentioned this pull request Aug 10, 2023
Closed
@wallentx wallentx closed this Aug 10, 2023
@wallentx wallentx reopened this Aug 10, 2023
emlowe
emlowe requested changes Aug 11, 2023
View reviewed changes
Copy link
Contributor

@emlowe emlowe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Doesn't seem to work in my testing

emlowe
emlowe approved these changes Aug 11, 2023
View reviewed changes
Copy link
Contributor

@emlowe emlowe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works as expected for me - loads of complaints on every refresh interval

@wallentx wallentx merged commit cbf971e into release/2.0.0 Aug 11, 2023
472 of 473 checks passed
@wallentx wallentx deleted the fc.dont_farm_with_no_context_2.0 branch August 11, 2023 18:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@emlowe emlowe emlowe approved these changes

Assignees
No one assigned
Labels
Fixed Required label for PR that categorizes merge commit message as "Fixed" for changelog
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Bug] 2.0.0-rc3 silently stops sending partials to a pool after a few minutes if a compressed plot is present
3 participants
@fchirica @emlowe @wallentx