New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support direct URL/links to app resources/actions such as Advanced Search, Layers, Manage etc. #115

Closed
rladines opened this Issue Sep 15, 2015 · 13 comments

Comments

Projects
None yet
4 participants
@rladines
Collaborator

rladines commented Sep 15, 2015

Only focus on Shareable Queries for now -- not adv search, layers, manage, etc.

Link to a query and executing that link.

@tomschenkjr

This comment has been minimized.

Show comment
Hide comment
@tomschenkjr

tomschenkjr Sep 15, 2015

Contributor

Like https://url.net/manage?

Contributor

tomschenkjr commented Sep 15, 2015

Like https://url.net/manage?

@rladines

This comment has been minimized.

Show comment
Hide comment
@rladines

rladines Sep 15, 2015

Collaborator

Right, or https://url.net/query?name=CouponTweets&autosubmit=true

It has to be designed so that the existing command buttons that currently invoke those panels/actions need to issue the same URL so it is consistent.

Collaborator

rladines commented Sep 15, 2015

Right, or https://url.net/query?name=CouponTweets&autosubmit=true

It has to be designed so that the existing command buttons that currently invoke those panels/actions need to issue the same URL so it is consistent.

@tomschenkjr

This comment has been minimized.

Show comment
Hide comment
@tomschenkjr

tomschenkjr Jun 15, 2016

Contributor

I agree. Can you mark #134 as duplicated and close it?

Contributor

tomschenkjr commented Jun 15, 2016

I agree. Can you mark #134 as duplicated and close it?

@tomschenkjr

This comment has been minimized.

Show comment
Hide comment
@tomschenkjr

tomschenkjr Jun 27, 2017

Contributor

Have been using this on WindyGrid, but noticing some issue. Namely, issues are arising when sending the link because some programs are truncating the URL after the # symbol that are being used to define the colors.

For instance, this link is being truncated when embedding the link in a Microsoft Outlook email (e.g., inserting a link).

The hash/pound symbols aren't being encoded. However, when switching # to %23, the links are able to be shared and are also being properly interpreted by WG.

Would it be possible to encode the # in the URL being generated by the application?

/cc @geneorama

Contributor

tomschenkjr commented Jun 27, 2017

Have been using this on WindyGrid, but noticing some issue. Namely, issues are arising when sending the link because some programs are truncating the URL after the # symbol that are being used to define the colors.

For instance, this link is being truncated when embedding the link in a Microsoft Outlook email (e.g., inserting a link).

The hash/pound symbols aren't being encoded. However, when switching # to %23, the links are able to be shared and are also being properly interpreted by WG.

Would it be possible to encode the # in the URL being generated by the application?

/cc @geneorama

@reve0716

This comment has been minimized.

Show comment
Hide comment
@reve0716

reve0716 Jun 28, 2017

Contributor

It works with newer version outlook and not with outlook desktop version 2010.

Contributor

reve0716 commented Jun 28, 2017

It works with newer version outlook and not with outlook desktop version 2010.

@tomschenkjr

This comment has been minimized.

Show comment
Hide comment
@tomschenkjr

tomschenkjr Jun 28, 2017

Contributor
Contributor

tomschenkjr commented Jun 28, 2017

@tomschenkjr

This comment has been minimized.

Show comment
Hide comment
@tomschenkjr

tomschenkjr Jun 30, 2017

Contributor

@nfspeedypur and @rladines - I see this issue is appearing in OpenGrid.io.

@rladines - did the patch you release in WindyGrid make it into the OpenGrid code or does that need to be ported?

Contributor

tomschenkjr commented Jun 30, 2017

@nfspeedypur and @rladines - I see this issue is appearing in OpenGrid.io.

@rladines - did the patch you release in WindyGrid make it into the OpenGrid code or does that need to be ported?

@rladines

This comment has been minimized.

Show comment
Hide comment
@rladines

rladines Jun 30, 2017

Collaborator

It should be there. These are the commits that were part of that fix:
Main.js
AdvancedSearch.js

@nfspeedypur Can you confirm that these were merged into the OpenGrid.io code?

Collaborator

rladines commented Jun 30, 2017

It should be there. These are the commits that were part of that fix:
Main.js
AdvancedSearch.js

@nfspeedypur Can you confirm that these were merged into the OpenGrid.io code?

@tomschenkjr

This comment has been minimized.

Show comment
Hide comment
@tomschenkjr

tomschenkjr Jun 30, 2017

Contributor

Ok, looks like I didn't do the test right on my end. Closing for now. Thanks everyone!

Contributor

tomschenkjr commented Jun 30, 2017

Ok, looks like I didn't do the test right on my end. Closing for now. Thanks everyone!

@tomschenkjr

@tomschenkjr tomschenkjr reopened this Jun 30, 2017

@tomschenkjr

This comment has been minimized.

Show comment
Hide comment
@tomschenkjr

tomschenkjr Jun 30, 2017

Contributor

I haven't been able to replicate the bug in WindyGrid, even by using the same query.

Contributor

tomschenkjr commented Jun 30, 2017

I haven't been able to replicate the bug in WindyGrid, even by using the same query.

@rladines

This comment has been minimized.

Show comment
Hide comment
@rladines

rladines Jul 13, 2017

Collaborator

@tomschenkjr was able to recreate this, even on the windygrid side. we had a bug where a single replace is done instead of global. should be fixed with branch iss115. I will submit a PR for the fix.

Collaborator

rladines commented Jul 13, 2017

@tomschenkjr was able to recreate this, even on the windygrid side. we had a bug where a single replace is done instead of global. should be fixed with branch iss115. I will submit a PR for the fix.

@tomschenkjr

This comment has been minimized.

Show comment
Hide comment
@tomschenkjr

tomschenkjr Aug 7, 2017

Contributor

Closed by 8fe5094

Contributor

tomschenkjr commented Aug 7, 2017

Closed by 8fe5094

@tomschenkjr tomschenkjr closed this Aug 7, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment