New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed "issues" link in README.md #314

Merged
merged 7 commits into from Jul 31, 2017

Conversation

Projects
None yet
4 participants
@cyanliu
Contributor

cyanliu commented Jul 11, 2017

Previously (or rather, currently) redirected to github.com/Chicago/issues rather than github.com/Chicago/opengrid/issues

rladines and others added some commits Jun 29, 2017

Merge pull request #304 from Chicago/dev
Milestone 1.4.0 changes
??

@cyanliu cyanliu changed the title from Fix issues link to Fixed "issues" link in README.md Jul 11, 2017

@tomschenkjr

This comment has been minimized.

Show comment
Hide comment
@tomschenkjr

tomschenkjr Jul 31, 2017

Contributor

@cyanliu - first off, thank you very much for noticing the issue and, moreover, taking the time to submit a pull request. We've reviewed your request and will be accepting it.

However, per our contributing documentation, we do require a contributor license agreement (CLA) to be signed before we may accept a pull request. The CLA ensures that you are authorized to submit the improvements to us. Sometimes, employers or others may have first-stake to any material you produce and a CLA ensures that.

Do let us know if you have any questions or concerns. Thanks!

Contributor

tomschenkjr commented Jul 31, 2017

@cyanliu - first off, thank you very much for noticing the issue and, moreover, taking the time to submit a pull request. We've reviewed your request and will be accepting it.

However, per our contributing documentation, we do require a contributor license agreement (CLA) to be signed before we may accept a pull request. The CLA ensures that you are authorized to submit the improvements to us. Sometimes, employers or others may have first-stake to any material you produce and a CLA ensures that.

Do let us know if you have any questions or concerns. Thanks!

@tomschenkjr tomschenkjr added this to the v1.4.1 milestone Jul 31, 2017

@cyanliu

This comment has been minimized.

Show comment
Hide comment
@cyanliu

cyanliu Jul 31, 2017

Contributor

Hi @tomschenkjr ! I apologize for not having done this sooner, I'm a little new to the world of open source projects and I definitely should have done a bit more research before submitting a pull request. Thanks for getting me all caught up, I've just finished signing the CLA!

Contributor

cyanliu commented Jul 31, 2017

Hi @tomschenkjr ! I apologize for not having done this sooner, I'm a little new to the world of open source projects and I definitely should have done a bit more research before submitting a pull request. Thanks for getting me all caught up, I've just finished signing the CLA!

@tomschenkjr

This comment has been minimized.

Show comment
Hide comment
@tomschenkjr

tomschenkjr Jul 31, 2017

Contributor

No problem! Thanks!

Contributor

tomschenkjr commented Jul 31, 2017

No problem! Thanks!

@tomschenkjr tomschenkjr changed the base branch from master to dev Jul 31, 2017

@tomschenkjr tomschenkjr merged commit 4a4f835 into Chicago:dev Jul 31, 2017

1 of 3 checks passed

continuous-integration/travis-ci/pr The Travis CI build failed
Details
continuous-integration/appveyor/pr Waiting for AppVeyor build to complete
Details
clahub All contributors have signed the Contributor License Agreement.
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment