New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added API key to OpenWeather calls #315

Merged
merged 9 commits into from Aug 7, 2017

Conversation

Projects
None yet
3 participants
@rladines
Collaborator

rladines commented Jul 17, 2017

No description provided.

rladines and others added some commits Jun 29, 2017

Merge pull request #304 from Chicago/dev
Milestone 1.4.0 changes

@rladines rladines requested review from tomschenkjr and nfspeedypur Jul 17, 2017

@rladines

This comment has been minimized.

Show comment
Hide comment
@rladines

rladines Jul 17, 2017

Collaborator

@tomschenkjr @nfspeedypur this should fix #301

Collaborator

rladines commented Jul 17, 2017

@tomschenkjr @nfspeedypur this should fix #301

@tomschenkjr

This comment has been minimized.

Show comment
Hide comment
@tomschenkjr

tomschenkjr Jul 21, 2017

Contributor

@rladines - this isn't the same key that is being used for WindyGrid, right?

Contributor

tomschenkjr commented Jul 21, 2017

@rladines - this isn't the same key that is being used for WindyGrid, right?

@rladines

This comment has been minimized.

Show comment
Hide comment
@rladines

rladines Jul 21, 2017

Collaborator

@tomschenkjr I used the same key for WindyGrid. I did not realize they were different until you asked. Is it ok to switch the keys i.e. use WG's for OpenGrid?

Collaborator

rladines commented Jul 21, 2017

@tomschenkjr I used the same key for WindyGrid. I did not realize they were different until you asked. Is it ok to switch the keys i.e. use WG's for OpenGrid?

@tomschenkjr

This comment has been minimized.

Show comment
Hide comment
@tomschenkjr

tomschenkjr Jul 21, 2017

Contributor
Contributor

tomschenkjr commented Jul 21, 2017

@rladines

This comment has been minimized.

Show comment
Hide comment
@rladines

rladines Jul 21, 2017

Collaborator

@tomschenkjr yes, I have the other key from the ticket detail

Collaborator

rladines commented Jul 21, 2017

@tomschenkjr yes, I have the other key from the ticket detail

rladines added some commits Jul 24, 2017

@tomschenkjr tomschenkjr changed the base branch from master to dev Jul 24, 2017

@tomschenkjr tomschenkjr added this to the v1.4.1 milestone Jul 31, 2017

@tomschenkjr

This comment has been minimized.

Show comment
Hide comment
@tomschenkjr

tomschenkjr Jul 31, 2017

Contributor

Another conflict with user documentation. Adding @reve0716 to help resolve it.

Contributor

tomschenkjr commented Jul 31, 2017

Another conflict with user documentation. Adding @reve0716 to help resolve it.

@tomschenkjr tomschenkjr merged commit cdc7155 into dev Aug 7, 2017

3 of 5 checks passed

continuous-integration/travis-ci/push The Travis CI build could not complete due to an error
Details
continuous-integration/travis-ci/pr The Travis CI build failed
Details
clahub All contributors have signed the Contributor License Agreement.
Details
continuous-integration/appveyor/branch AppVeyor build succeeded
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
@reve0716

This comment has been minimized.

Show comment
Hide comment
@reve0716

reve0716 Aug 23, 2017

Contributor

Tested Open Weather Layers for OG against how it works in WG
WindyGrid - weather layers all function properly
OpenGrid - weather layers function properly except Cloud Cover (doesn't appear but shows in WindyGrid)

Contributor

reve0716 commented Aug 23, 2017

Tested Open Weather Layers for OG against how it works in WG
WindyGrid - weather layers all function properly
OpenGrid - weather layers function properly except Cloud Cover (doesn't appear but shows in WindyGrid)

@tomschenkjr

This comment has been minimized.

Show comment
Hide comment
@tomschenkjr

tomschenkjr Aug 23, 2017

Contributor

I can also confirm the issue. Below is the console output when trying to view cloud cover:

image

Contributor

tomschenkjr commented Aug 23, 2017

I can also confirm the issue. Below is the console output when trying to view cloud cover:

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment