Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

Respond to apple-touch-icon.png in root directory. #207

Merged
merged 1 commit into from Feb 7, 2013

Conversation

Projects
None yet
3 participants
Contributor

davidw commented Feb 7, 2013

My Nexus 7 tries to grab this file, and presumably, so do other mobile/tablet devices, so I copied the favicon.ico behavior.

Contributor

evanmiller commented Feb 7, 2013

Man, Apple sucks. But that is the world we live in.

@evanmiller evanmiller added a commit that referenced this pull request Feb 7, 2013

@evanmiller evanmiller Merge pull request #207 from davidw/master
Respond to apple-touch-icon.png in root directory.
7bac36e

@evanmiller evanmiller merged commit 7bac36e into ChicagoBoss:master Feb 7, 2013

Contributor

davidw commented Feb 7, 2013

Not a fan of Apple either, but it seems to have become a new standard in that my Android tablet is asking for the same file.

There's also a /apple-touch-icon-precomposed.png file as well, perhaps we should add that for completeness' sake.

Contributor

evanmiller commented Feb 7, 2013

There's not a way to specify this crap in the HTML?

Contributor

davidw commented Feb 7, 2013

There's some relevant HTML, but the filename is hard coded. Another approach would be to rip out hard-coding them in CB, and add these files to the default routes file somehow.

Contributor

evanmiller commented Feb 7, 2013

Hmm. I think the problem is that you can't route to a static resource in the router. I'm OK with hardcoding for now.

Contributor

jgordor commented Feb 7, 2013

There are specific metas like

<link href="/static/images/h/apple-touch-icon.png" sizes="114x114" rel="apple-touch-icon">

Just implemented this last week and revert all the mess in the nginx config

Best

Contributor

davidw commented Feb 7, 2013

It (well, my Nexus 7) looks for the files even without the tags.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment