ChihChengLiang
Follow
Pinned
2,516 contributions in the last year
Less
More
Contribution activity
February 2021
Created 1 repository
- ChihChengLiang/Solidity-Notes Solidity
Created a pull request in thehubbleproject/hubble-commander that received 2 comments
Refactor REST API handler
What's wrong In our REST API handler, the server processing logic is mangled together with the REST logic. There are some disadvantages here: Code…
+85
−166
•
2
comments
Opened 33 other pull requests in 4 repositories
thehubbleproject/hubble-contracts
8
open
15
merged
1
closed
- auto label changes and change release format
- Storage engine
- add naive tx-pool
- add deterministic public key
- organize deployAndWriteGenesis
- Js client prototype
- move Proof of Burn to test
- Add the rest of the immutables
- Add immutable to Rollup.sol/BatchManager.sol to reduce SLOAD
- improve key registry event gas efficiency
- Apply SafeERC20 on depositManager and WithdrawManager
- caching storage value
- Fix typo
- Register token in different decimals
- Add deposit subtreeID
- Separate Float and FixedNumber
- remove amount greater than 0 requirement
- Add account root to log
- Mid size insert account
- deposit in burn auction
- different style of avoiding damaging merklise input data
- Inherit error properly
- Enable keyless deployment
- [Presentation] Reviews on visibilities
thehubbleproject/hubble-commander
4
merged
1
open
thehubbleproject/hubble-bls
3
merged
ChihChengLiang/milagro_bls_binding
1
merged
Reviewed 15 pull requests in 4 repositories
thehubbleproject/hubble-commander 9 pull requests
thehubbleproject/hubble-contracts 4 pull requests
ethereum/eth2.0-specs 1 pull request
thehubbleproject/hubble-bls 1 pull request
Created an issue in thehubbleproject/hubble-contracts that received 3 comments
Use withdraw pattern in the rollback
What's wrong Currently, in our rollback function, we directly send the reward to the disputer. This frontrunner can detect balance change easily an…
3
comments
Opened 24 other issues in 3 repositories
thehubbleproject/hubble-contracts
13
open
9
closed
- Add Proposer
- Add Transaction pool
- Add RPC client
- Add Watcher
- Add Provider
- Tricks to pry data out of internal transaction
- SpokeRegistry has no access control
- Remove not-indexed calldata-dependent fields from events for better gas optimization
- Typos to fix
- BurnAuction deposits update is inefficient
- Use SafeERC20 to support non-standard tokens
- Disable Proof of burn chooser
- Ownership of tokenRegistry
- setRollupAddress in depositManager and Vault has no access control
- Scripts to add 4 tokens and fee receivers for dev case
- Decimal 18 token
- Deposit subtree needs an unique identifier
- [Discussion] Max commitment per batch is an implicit parameter
- Add a deposit function in the burn auction
- frontendTransfer.validate doesn't raise when revert
- Add keyless deployment to deploy script
- DEPTH in the AccountTree is misleading