New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chat Messages Not Being Relayed To Discord #131

Open
InsomniaKitten opened this Issue Mar 9, 2018 · 4 comments

Comments

Projects
None yet
3 participants
@InsomniaKitten
Copy link

InsomniaKitten commented Mar 9, 2018

Everything seems to be relayed from Minecraft -> Discord except for actual chat messages. I'm not sure if I have set something up incorrectly, but I have triple checked my config and it seems fine. Chat messages don't seem to be displaying on my server console either.

DiscordIntegration version: 1.12.2-3.0.4
Forge version: 1.12.2-14.23.2.2624
Configuration: gist:discordintegration.json

@InsomniaKitten

This comment has been minimized.

Copy link
Author

InsomniaKitten commented Mar 10, 2018

I have found the source of the issue. I forgot I had a Charset tweak enabled which mutes chat based on distance from the player. The relevant code can be seen below:

pl.asie.charset.module.tweak.chat.CharsetTweakChat.java#L140-L144

The solution would be to use EventPriority#LOW at MinecraftListener.java#L215, and in turn, @asiekierka should be using EventPriority#LOWEST to ensure monitoring and distance culling of messages occurs after any potential modification to the message component has occurred - which is an ideal change regardless of this issue.

@asiekierka

This comment has been minimized.

Copy link

asiekierka commented Mar 11, 2018

What's the point of using distance-based chat if you're just relaying everything to a botnDiscord?

It would be better for me to be able to somehow relay those messages which are not distance-based ("shout" messages) to DiscordIntegration, and back.

@Chikachi

This comment has been minimized.

Copy link
Owner

Chikachi commented Mar 11, 2018

Yeah, it doesn't make much sense for distance-based chat.
DiscordIntegration supports IMC messages to allow for sending/receiving Discord messages.

@asiekierka

This comment has been minimized.

Copy link

asiekierka commented Mar 11, 2018

sendRuntimeMessage

Well, that's something I've never heard of. Hm! I might end up supporting this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment