Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix part of the docstrings doctests #7

Merged
merged 1 commit into from Apr 18, 2018
Merged

Conversation

@lesteve
Copy link
Contributor

lesteve commented Apr 18, 2018

It started by wanting to remove the psyplot.docstring occurences but while I was at it I quickly looked at the doctests and fixed the easy one.

I had a quick look, and FYI you still have failures in your doctests. To reproduce:

pytest docrep --doctest-modules 

I am not sure some of the stuff you are doing is easy to test with doctest (e.g. multi-line expected outputs with blank lines in the middle or expected exceptions) so maybe # doctest: +SKIP is the right approach and/or moving some of your doctest code to tests.

@coveralls

This comment has been minimized.

Copy link

coveralls commented Apr 18, 2018

Coverage Status

Coverage remained the same at 96.216% when pulling a24ce35 on lesteve:fix-some-doctests into 5ab5339 on Chilipp:master.

2 similar comments
@coveralls

This comment has been minimized.

Copy link

coveralls commented Apr 18, 2018

Coverage Status

Coverage remained the same at 96.216% when pulling a24ce35 on lesteve:fix-some-doctests into 5ab5339 on Chilipp:master.

@coveralls

This comment has been minimized.

Copy link

coveralls commented Apr 18, 2018

Coverage Status

Coverage remained the same at 96.216% when pulling a24ce35 on lesteve:fix-some-doctests into 5ab5339 on Chilipp:master.

@Chilipp

This comment has been minimized.

Copy link
Owner

Chilipp commented Apr 18, 2018

Thanks @lesteve ! Those are good points. I fix this and implement the doctest in the CI config

@Chilipp Chilipp merged commit 2c8ab4d into Chilipp:master Apr 18, 2018
2 checks passed
2 checks passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
coverage/coveralls Coverage remained the same at 96.216%
Details
Chilipp added a commit that referenced this pull request Apr 18, 2018
as mentioned in #7
@Chilipp Chilipp mentioned this pull request Apr 18, 2018
@lesteve

This comment has been minimized.

Copy link
Contributor Author

lesteve commented Apr 19, 2018

Great to hear that!

@lesteve lesteve deleted the lesteve:fix-some-doctests branch Apr 19, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.