Fix Public API Github Action (#4366)

ChilliCream · Nov 8, 2021 · e202ffc · e202ffc
1 parent d1b0160
commit e202ffc
Show file tree

Hide file tree

Showing 9 changed files with 41 additions and 24 deletions.
diff --git a/.build/Build.PublicApiAnalyzer.cs b/.build/Build.PublicApiAnalyzer.cs
@@ -28,7 +28,7 @@ partial class Build : NukeBuild
         .Executes(() =>
         {
             Helpers.TryDelete(PublicApiSolutionFile);
-            
+
             DotNetBuildSonarSolution(
                 PublicApiSolutionFile,
                 include: file =>
@@ -43,7 +43,7 @@ partial class Build : NukeBuild
         });
 
     Target AddUnshippedApi => _ => _
-        .DependsOn(Restore) 
+        .DependsOn(Restore)
         .Executes(() =>
         {
             TryDelete(PublicApiSolutionFile);
@@ -54,11 +54,8 @@ partial class Build : NukeBuild
                     !Path.GetFileNameWithoutExtension(file)
                         .EndsWith("tests", StringComparison.OrdinalIgnoreCase));
 
-            // new we restore our local dotnet tools including dotnet-format
-            DotNetToolRestore(c => c.SetProcessWorkingDirectory(RootDirectory));
-
             // last we run the actual dotnet format command.
-            DotNet($@"format ""{PublicApiSolutionFile}"" --fix-analyzers warn --diagnostics RS0016", workingDirectory: RootDirectory);
+            DotNet($@"format ""{PublicApiSolutionFile}"" analyzers --diagnostics=RS0016", workingDirectory: RootDirectory);
         });
 
     Target DiffShippedApi => _ => _

diff --git a/.config/dotnet-tools.json b/.config/dotnet-tools.json
@@ -4,27 +4,15 @@
   "tools": {
     "dotnet-sonarscanner": {
       "version": "4.8.0",
-      "commands": [
-        "dotnet-sonarscanner"
-      ]
+      "commands": ["dotnet-sonarscanner"]
     },
     "boost.tool": {
       "version": "0.2.6",
-      "commands": [
-        "boo"
-      ]
-    },
-    "dotnet-format": {
-      "version": "5.1.225507",
-      "commands": [
-        "dotnet-format"
-      ]
+      "commands": ["boo"]
     },
     "nuke.globaltool": {
       "version": "5.1.2",
-      "commands": [
-        "nuke"
-      ]
+      "commands": ["nuke"]
     }
   }
-}
+}
diff --git a/.editorconfig b/.editorconfig
@@ -165,3 +165,6 @@ csharp_new_line_before_members_in_object_initializers = true
 csharp_new_line_before_members_in_anonymous_types = true
 
 dotnet_style_require_accessibility_modifiers = always
+
+# Public API
+dotnet_diagnostic.RS0016.severity = warning
diff --git a/.github/workflows/check-public-api.yml b/.github/workflows/check-public-api.yml
@@ -13,5 +13,7 @@ jobs:
     steps:
       - uses: actions/checkout@v2
       - uses: actions/setup-dotnet@v1
+        with:
+          dotnet-version: '6.0.100'
       - run:  ./build.sh CheckPublicApi
-        name: "Check for undocumented public API changes"
+        name: "Check for undocumented public API changes"
diff --git a/src/Directory.Build.props b/src/Directory.Build.props
@@ -51,7 +51,7 @@
   </PropertyGroup>
 
   <ItemGroup Condition=" $(AddPublicApiAnalyzers) ">
-    <PackageReference Include="Microsoft.CodeAnalysis.PublicApiAnalyzers" Version="3.3.2">
+    <PackageReference Include="Microsoft.CodeAnalysis.PublicApiAnalyzers" Version="3.3.3">
       <ExcludeAssets>compile</ExcludeAssets>
       <PrivateAssets>all</PrivateAssets>
     </PackageReference>

diff --git a/src/HotChocolate/AspNetCore/src/AspNetCore.Authorization/PublicAPI.Unshipped.txt b/src/HotChocolate/AspNetCore/src/AspNetCore.Authorization/PublicAPI.Unshipped.txt
@@ -0,0 +1,12 @@
+HotChocolate.AspNetCore.Authorization.AuthorizeResult
+HotChocolate.AspNetCore.Authorization.AuthorizeResult.Allowed = 0 -> HotChocolate.AspNetCore.Authorization.AuthorizeResult
+HotChocolate.AspNetCore.Authorization.AuthorizeResult.NoDefaultPolicy = 3 -> HotChocolate.AspNetCore.Authorization.AuthorizeResult
+HotChocolate.AspNetCore.Authorization.AuthorizeResult.NotAllowed = 1 -> HotChocolate.AspNetCore.Authorization.AuthorizeResult
+HotChocolate.AspNetCore.Authorization.AuthorizeResult.NotAuthenticated = 2 -> HotChocolate.AspNetCore.Authorization.AuthorizeResult
+HotChocolate.AspNetCore.Authorization.AuthorizeResult.PolicyNotFound = 4 -> HotChocolate.AspNetCore.Authorization.AuthorizeResult
+HotChocolate.AspNetCore.Authorization.DefaultAuthorizationHandler
+HotChocolate.AspNetCore.Authorization.DefaultAuthorizationHandler.AuthorizeAsync(HotChocolate.Resolvers.IMiddlewareContext! context, HotChocolate.AspNetCore.Authorization.AuthorizeDirective! directive) -> System.Threading.Tasks.ValueTask<HotChocolate.AspNetCore.Authorization.AuthorizeResult>
+HotChocolate.AspNetCore.Authorization.DefaultAuthorizationHandler.DefaultAuthorizationHandler() -> void
+HotChocolate.AspNetCore.Authorization.IAuthorizationHandler
+HotChocolate.AspNetCore.Authorization.IAuthorizationHandler.AuthorizeAsync(HotChocolate.Resolvers.IMiddlewareContext! context, HotChocolate.AspNetCore.Authorization.AuthorizeDirective! directive) -> System.Threading.Tasks.ValueTask<HotChocolate.AspNetCore.Authorization.AuthorizeResult>
+static Microsoft.Extensions.DependencyInjection.HotChocolateAuthorizeRequestExecutorBuilder.AddAuthorizationHandler<T>(this HotChocolate.Execution.Configuration.IRequestExecutorBuilder! builder) -> HotChocolate.Execution.Configuration.IRequestExecutorBuilder!
diff --git a/src/HotChocolate/AzureFunctions/src/HotChocolate.AzureFunctions/PublicAPI.Shipped.txt b/src/HotChocolate/AzureFunctions/src/HotChocolate.AzureFunctions/PublicAPI.Shipped.txt
@@ -0,0 +1 @@
+#nullable enable
diff --git a/src/HotChocolate/AzureFunctions/src/HotChocolate.AzureFunctions/PublicAPI.Unshipped.txt b/src/HotChocolate/AzureFunctions/src/HotChocolate.AzureFunctions/PublicAPI.Unshipped.txt
@@ -0,0 +1,10 @@
+#nullable enable
+HotChocolate.AzureFunctions.GraphQLAttribute
+HotChocolate.AzureFunctions.GraphQLAttribute.GraphQLAttribute() -> void
+HotChocolate.AzureFunctions.IGraphQLRequestExecutor
+HotChocolate.AzureFunctions.IGraphQLRequestExecutor.ExecuteAsync(Microsoft.AspNetCore.Http.HttpRequest! request) -> System.Threading.Tasks.Task<Microsoft.AspNetCore.Mvc.IActionResult!>!
+Microsoft.Azure.Functions.Extensions.DependencyInjection.HotChocolateFunctionsHostBuilderExtensions
+Microsoft.Extensions.DependencyInjection.HotChocolateAzureFunctionServiceCollectionExtensions
+static Microsoft.Azure.Functions.Extensions.DependencyInjection.HotChocolateFunctionsHostBuilderExtensions.AddGraphQLFunction(this Microsoft.Azure.Functions.Extensions.DependencyInjection.IFunctionsHostBuilder! builder, int maxAllowedRequestSize = 20000000, string! apiRoute = "/api/graphql") -> HotChocolate.Execution.Configuration.IRequestExecutorBuilder!
+static Microsoft.Extensions.DependencyInjection.HotChocolateAzureFunctionServiceCollectionExtensions.AddGraphQLFunction(this Microsoft.Extensions.DependencyInjection.IServiceCollection! services, int maxAllowedRequestSize = 20000000, string! apiRoute = "/api/graphql") -> HotChocolate.Execution.Configuration.IRequestExecutorBuilder!
+static Microsoft.Extensions.DependencyInjection.HotChocolateAzureFunctionServiceCollectionExtensions.ModifyFunctionOptions(HotChocolate.Execution.Configuration.IRequestExecutorBuilder! builder, System.Action<HotChocolate.AspNetCore.GraphQLServerOptions!>! configure) -> HotChocolate.Execution.Configuration.IRequestExecutorBuilder!
diff --git a/src/HotChocolate/Data/src/Data/PublicAPI.Unshipped.txt b/src/HotChocolate/Data/src/Data/PublicAPI.Unshipped.txt
@@ -1,3 +1,6 @@
+HotChocolate.Data.Filters.IdOperationFilterInputType
+HotChocolate.Data.Filters.IdOperationFilterInputType.IdOperationFilterInputType() -> void
+HotChocolate.Data.Filters.IdOperationFilterInputType.IdOperationFilterInputType(System.Action<HotChocolate.Data.Filters.IFilterInputTypeDescriptor!>! configure) -> void
 HotChocolate.Data.UseFilteringAttribute.UseFilteringAttribute(System.Type? filterType = null, int order = 0) -> void
 HotChocolate.Data.UseFirstOrDefaultAttribute.UseFirstOrDefaultAttribute(int order = 0) -> void
 HotChocolate.Data.UseProjectionAttribute.UseProjectionAttribute(int order = 0) -> void
@@ -8,3 +11,4 @@ HotChocolate.Data.UseSortingAttribute.UseSortingAttribute(System.Type? sortingTy
 *REMOVED*HotChocolate.Data.UseSortingAttribute.UseSortingAttribute(System.Type? sortingType = null) -> void
 *REMOVED*HotChocolate.Data.UseFirstOrDefaultAttribute.UseFirstOrDefaultAttribute() -> void
 *REMOVED*HotChocolate.Data.UseSingleOrDefaultAttribute.UseSingleOrDefaultAttribute() -> void
+override HotChocolate.Data.Filters.IdOperationFilterInputType.Configure(HotChocolate.Data.Filters.IFilterInputTypeDescriptor! descriptor) -> void