Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix small issues in Star Wars example #49

Merged
merged 2 commits into from Sep 30, 2019

Conversation

@Daniel15
Copy link
Contributor

commented Sep 29, 2019

  • Changes the port number to reflect what the code actually uses (1293)
  • Updated URL to include /graphql prefix
  • Formatted example GraphQL query the way that GraphiQL formats it

Closes ChilliCream/hotchocolate#1092

@rstaib

This comment has been minimized.

Copy link
Member

commented Sep 30, 2019

@Daniel15 and @michaelstaib we have to preconfigure the port to 5000; otherwise I assume everyone is having a different port than 5000.

@Daniel15

This comment has been minimized.

Copy link
Contributor Author

commented Sep 30, 2019

Good catch - I was running via Visual Studio, which might set the port number dynamically. I'll adjust the text to instead tell people to look for the "Now listening on:" output and use the port number there.

@michaelstaib

This comment has been minimized.

Copy link
Member

commented Sep 30, 2019

@Daniel15 I just added a note that the port may vary.

@michaelstaib michaelstaib merged commit a4ce2bd into ChilliCream:master Sep 30, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.