New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Apollo Tracing Support #465

Merged
merged 27 commits into from Jan 9, 2019

Conversation

Projects
None yet
2 participants
@rstaib
Copy link
Collaborator

rstaib commented Jan 7, 2019

No description provided.

@rstaib rstaib requested a review from michaelstaib Jan 7, 2019

@rstaib rstaib self-assigned this Jan 8, 2019

rstaib and others added some commits Jan 8, 2019

@rstaib rstaib force-pushed the apollo-tracing branch from 6c69ae5 to 9f55983 Jan 8, 2019

rstaib and others added some commits Jan 9, 2019

@michaelstaib michaelstaib added this to the 0.7.0 milestone Jan 9, 2019

@sonarcloud
Copy link

sonarcloud bot left a comment

SonarQube analysis found issues:
Bug Bugs: 0
Vulnerability Vulnerabilities: 0
Code Smell Code Smells: 24

Including the following issue(s) which could not be reported in line:

  1. Code Smell Code Smell: Add '.ConfigureAwait(false)' to this call to allow execution to continue in any thread. (more)
  2. Code Smell Code Smell: Add '.ConfigureAwait(false)' to this call to allow execution to continue in any thread. (more)
  3. Code Smell Code Smell: Add '.ConfigureAwait(false)' to this call to allow execution to continue in any thread. (more)
  4. Code Smell Code Smell: Add '.ConfigureAwait(false)' to this call to allow execution to continue in any thread. (more)
  5. Code Smell Code Smell: Add '.ConfigureAwait(false)' to this call to allow execution to continue in any thread. (more)
  6. Code Smell Code Smell: Add '.ConfigureAwait(false)' to this call to allow execution to continue in any thread. (more)
  7. Code Smell Code Smell: Add '.ConfigureAwait(false)' to this call to allow execution to continue in any thread. (more)
  8. Code Smell Code Smell: Add '.ConfigureAwait(false)' to this call to allow execution to continue in any thread. (more)
  9. Code Smell Code Smell: Add '.ConfigureAwait(false)' to this call to allow execution to continue in any thread. (more)
  10. Code Smell Code Smell: Add '.ConfigureAwait(false)' to this call to allow execution to continue in any thread. (more)
  11. Code Smell Code Smell: Add '.ConfigureAwait(false)' to this call to allow execution to continue in any thread. (more)
  12. Code Smell Code Smell: Add '.ConfigureAwait(false)' to this call to allow execution to continue in any thread. (more)
  13. Code Smell Code Smell: Add '.ConfigureAwait(false)' to this call to allow execution to continue in any thread. (more)
  14. Code Smell Code Smell: Add '.ConfigureAwait(false)' to this call to allow execution to continue in any thread. (more)
  15. Code Smell Code Smell: Add '.ConfigureAwait(false)' to this call to allow execution to continue in any thread. (more)
  16. Code Smell Code Smell: Add '.ConfigureAwait(false)' to this call to allow execution to continue in any thread. (more)

See all issues in SonarCloud

@sonarcloud
Copy link

sonarcloud bot left a comment

SonarQube analysis found issues:
Bug Bugs: 0
Vulnerability Vulnerabilities: 0
Code Smell Code Smells: 25

Including the following issue(s) which could not be reported in line:

  1. Code Smell Code Smell: Add '.ConfigureAwait(false)' to this call to allow execution to continue in any thread. (more)
  2. Code Smell Code Smell: Add '.ConfigureAwait(false)' to this call to allow execution to continue in any thread. (more)
  3. Code Smell Code Smell: Add '.ConfigureAwait(false)' to this call to allow execution to continue in any thread. (more)
  4. Code Smell Code Smell: Add '.ConfigureAwait(false)' to this call to allow execution to continue in any thread. (more)
  5. Code Smell Code Smell: Add '.ConfigureAwait(false)' to this call to allow execution to continue in any thread. (more)
  6. Code Smell Code Smell: Add '.ConfigureAwait(false)' to this call to allow execution to continue in any thread. (more)
  7. Code Smell Code Smell: Add '.ConfigureAwait(false)' to this call to allow execution to continue in any thread. (more)
  8. Code Smell Code Smell: Add '.ConfigureAwait(false)' to this call to allow execution to continue in any thread. (more)
  9. Code Smell Code Smell: Add '.ConfigureAwait(false)' to this call to allow execution to continue in any thread. (more)
  10. Code Smell Code Smell: Add '.ConfigureAwait(false)' to this call to allow execution to continue in any thread. (more)
  11. Code Smell Code Smell: Add '.ConfigureAwait(false)' to this call to allow execution to continue in any thread. (more)
  12. Code Smell Code Smell: Add '.ConfigureAwait(false)' to this call to allow execution to continue in any thread. (more)
  13. Code Smell Code Smell: Add '.ConfigureAwait(false)' to this call to allow execution to continue in any thread. (more)
  14. Code Smell Code Smell: Add '.ConfigureAwait(false)' to this call to allow execution to continue in any thread. (more)
  15. Code Smell Code Smell: Add '.ConfigureAwait(false)' to this call to allow execution to continue in any thread. (more)
  16. Code Smell Code Smell: Add '.ConfigureAwait(false)' to this call to allow execution to continue in any thread. (more)

See all issues in SonarCloud

michaelstaib and others added some commits Jan 9, 2019

@sonarcloud
Copy link

sonarcloud bot left a comment

SonarQube analysis found issues:
Bug Bugs: 1
Vulnerability Vulnerabilities: 0
Code Smell Code Smells: 13

Including the following issue(s) which could not be reported in line:

  1. Code Smell Code Smell: Add '.ConfigureAwait(false)' to this call to allow execution to continue in any thread. (more)
  2. Code Smell Code Smell: Add '.ConfigureAwait(false)' to this call to allow execution to continue in any thread. (more)
  3. Code Smell Code Smell: Add '.ConfigureAwait(false)' to this call to allow execution to continue in any thread. (more)
  4. Code Smell Code Smell: Add '.ConfigureAwait(false)' to this call to allow execution to continue in any thread. (more)
  5. Code Smell Code Smell: Add '.ConfigureAwait(false)' to this call to allow execution to continue in any thread. (more)
  6. Code Smell Code Smell: Add '.ConfigureAwait(false)' to this call to allow execution to continue in any thread. (more)
  7. Code Smell Code Smell: Add '.ConfigureAwait(false)' to this call to allow execution to continue in any thread. (more)
  8. Code Smell Code Smell: Add '.ConfigureAwait(false)' to this call to allow execution to continue in any thread. (more)
  9. Code Smell Code Smell: Add '.ConfigureAwait(false)' to this call to allow execution to continue in any thread. (more)
  10. Code Smell Code Smell: Add '.ConfigureAwait(false)' to this call to allow execution to continue in any thread. (more)
  11. Code Smell Code Smell: Add '.ConfigureAwait(false)' to this call to allow execution to continue in any thread. (more)

See all issues in SonarCloud

rstaib added some commits Jan 9, 2019

@sonarcloud
Copy link

sonarcloud bot left a comment

SonarQube analysis found issues:
Bug Bugs: 0
Vulnerability Vulnerabilities: 0
Code Smell Code Smells: 2

See all issues in SonarCloud

@rstaib rstaib merged commit 473a828 into master Jan 9, 2019

5 checks passed

Better Code Hub ☕ Don’t forget to refactor
Details
SonarCloud Code Quality check passed; 89.8% Coverage; 0.0% Duplication
Details
ci/circleci: pull-request Your tests passed on CircleCI!
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@rstaib rstaib deleted the apollo-tracing branch Jan 9, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment