Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed Issue #629 #630

Merged
merged 3 commits into from Mar 13, 2019

Conversation

Projects
None yet
2 participants
@rstaib
Copy link
Member

rstaib commented Mar 12, 2019

Fixes #629

rstaib added some commits Mar 12, 2019

@rstaib rstaib self-assigned this Mar 12, 2019

@rstaib rstaib requested a review from michaelstaib Mar 12, 2019

@@ -115,5 +150,14 @@ private static long GetStartTimestamp()
return Convert.ToInt64(Activity.Current.Tags
.First(t => t.Key == _startTimestampKey).Value);
}

private bool IsEnabled(object context)

This comment has been minimized.

@michaelstaib

michaelstaib Mar 12, 2019

Member

So, the outer IsEnabled is now completely obsolete?
To have it here in the Apollo Tracing Observer seems even to make more sense, since this is only related to this specific observer.

@michaelstaib

This comment has been minimized.

Copy link
Member

michaelstaib commented Mar 12, 2019

do not forget to update the build solutions in the tools folder, I think this is why it does not build.

tools/Build.sln and tools/Build.Core.sln

@michaelstaib

This comment has been minimized.

Copy link
Member

michaelstaib commented Mar 12, 2019

I will start updating the documentation for this one...

@michaelstaib

This comment has been minimized.

Copy link
Member

michaelstaib commented Mar 13, 2019

The build is now fixed.

@michaelstaib michaelstaib merged commit 7f9077e into master Mar 13, 2019

4 checks passed

Better Code Hub ✅ Nice job!
Details
ci/circleci: pull-request Your tests passed on CircleCI!
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@michaelstaib michaelstaib deleted the fix-diagnostics branch Mar 13, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.
You signed in with another tab or window. Reload to refresh your session. You signed out in another tab or window. Reload to refresh your session.