Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stutter when updating blocks in chunk with connected Chisel textures 1.12.2 #53

Open
Silver-Wulf opened this issue Apr 9, 2018 · 3 comments

Comments

Projects
None yet
2 participants
@Silver-Wulf
Copy link

commented Apr 9, 2018

I was experiencing a bit of a frame stutter when breaking/placing blocks while making a spawn so I decided to do some research. I was led to this post https://www.reddit.com/r/feedthebeast/comments/5wkwby/sf3_lag_spikes_when_breaking_and_placing_blocks/ which led me to test whether blocks with connected textures caused the chunk containing them to be slow to refresh. Sure enough the stuttering was easily recreated even on my GTX 1080 by placing a large amount of a Chisel block that has connected textures in a single chunk and spamming break/place on a block in the same chunk (doesnt need to be the chisel block). I then tried the same process in another chunk using some random block from XTones that did not use any connected textures (may as well be stone) and I did not encounter the issue. I am using the latest release version of Chisel for 1.12.2.

Carpet is from chisel, the other block is a random block from another mod with no connected textures.
Stone is used for breaking/placing and is not required to be touching either tested block.

2018-04-09_15 36 49
2018-04-09_15 36 54
2018-04-09_15 37 08
2018-04-09_15 37 24

@tterrag1098

This comment has been minimized.

Copy link
Member

commented Apr 10, 2018

As far as I know, this is simply the cost of having higher-poly models (which CTM models are). CTM works by splitting each block face into 4 quadrants and assigning each quadrant a piece of the bigger texture. This means, unfortunately, that all blocks with CTM have 4x as many faces as normal blocks (if all sides are visible, 24 instead of 6). I have profiled the speed of our code again and again, and come to the conclusion that it is simply the smooth lighting code that runs slower due to there being more quads in the pipeline. If you can give me a profiler that points to some excessive source of lag in CTM I would happily fix it, as I would like this issue to be gone as much as you. But as it stands, there's not much that can be done.

@tterrag1098

This comment has been minimized.

Copy link
Member

commented Apr 10, 2018

Additionally, you may be able to boost your FPS (at the cost of some slight chunk update delay) by enabling the forge "Force threaded chunk renedering" config option, in "Client Settings"

@Silver-Wulf

This comment has been minimized.

Copy link
Author

commented Apr 11, 2018

Thank you for the feedback. I will certainly profile my client when I get the opportunity. I was more concerned that in a modded server with autonomous block breaking/placing lag may be an issue in compact bases. I will post here if I run into any more information.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.