From 07ac6015d040ca793457cedd8102461f14a7fb1c Mon Sep 17 00:00:00 2001 From: Chocobo1 Date: Fri, 1 Mar 2024 16:30:39 +0800 Subject: [PATCH] GHA CI: disable security hardening flag OpenSSL isn't compatible with `/guard:cf` flag so we omit it for now. Related: https://github.com/openssl/openssl/issues/22554 Closes #20479. PR #20487. --- .github/workflows/ci_windows.yaml | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/.github/workflows/ci_windows.yaml b/.github/workflows/ci_windows.yaml index e6aeb4bd60..77fa314420 100644 --- a/.github/workflows/ci_windows.yaml +++ b/.github/workflows/ci_windows.yaml @@ -50,15 +50,13 @@ jobs: -Force ` -ItemType File ` -Path "${{ env.vpkg_triplet_path }}/x64-windows-static-md-release.cmake" + # OpenSSL isn't compatible with `/guard:cf` flag so we omit it for now, see: https://github.com/openssl/openssl/issues/22554 Add-Content ` -Path "${{ env.vpkg_triplet_path }}/x64-windows-static-md-release.cmake" ` -Value @("set(VCPKG_TARGET_ARCHITECTURE x64)", "set(VCPKG_LIBRARY_LINKAGE static)", "set(VCPKG_CRT_LINKAGE dynamic)", - "set(VCPKG_BUILD_TYPE release)", - "set(VCPKG_C_FLAGS /guard:cf)", - "set(VCPKG_CXX_FLAGS /guard:cf)", - "set(VCPKG_LINKER_FLAGS /guard:cf)") + "set(VCPKG_BUILD_TYPE release)") # clear buildtrees after each package installation to reduce disk space requirements $packages = ` "openssl:x64-windows-static-md-release",