Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.Sign up
Embeds and video playback don't work with Brave browser #1374
Visitors to my instance have reported two variants of this bug:
So, this clearly seems like unwelcome behavior on the part of Brave, but after having several visitors report this to me as broken behavior, I'm wondering if there's something we can do on our side to mitigate it.
One straw-man approach may be to simply disable P2P selectively when the client is running on Brave, or even by detecting the Webtorrent plugin. Maybe we can do better though. Perhaps we could offer a varient of the .torrent file under a different mime type.
I'm running Brave 0.25.2 (8ea2a9c) which claims to be the latest, and the bug is still reproducible. But if there's a fix upstream that just needs to come out in a release, that's good. If there's no upstream fix on the way, I'd argue that this might be worth a mitigation in PeerTube, which is why I filed the bug here.