Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Embeds and video playback don't work with Brave browser #1374

Open
scanlime opened this issue Nov 4, 2018 · 3 comments

Comments

@scanlime
Copy link
Contributor

commented Nov 4, 2018

Visitors to my instance have reported two variants of this bug:

  • In the default configuration, there's a Webtorrent plugin which will intercept any fetch() or XHR of a .torrent file and redirect the page to a torrent client. This means that as soon as a video playback page loads, it redirects to a plain torrent client page. Even if the user wants to use this for video playback, it's missing the rest of the PeerTube UI, such as the comments and navigation.

  • In embedded videos, the player displays an error message on an otherwise black screen, claiming the remote PeerTube instance can't be reached. If you click the embed, it redirects to the torrent client.

So, this clearly seems like unwelcome behavior on the part of Brave, but after having several visitors report this to me as broken behavior, I'm wondering if there's something we can do on our side to mitigate it.

One straw-man approach may be to simply disable P2P selectively when the client is running on Brave, or even by detecting the Webtorrent plugin. Maybe we can do better though. Perhaps we could offer a varient of the .torrent file under a different mime type.

@Nutomic

This comment has been minimized.

Copy link
Contributor

commented Nov 4, 2018

The Brave issue for this is reported fixed: brave/browser-laptop#10672

Also see #218.

@scanlime

This comment has been minimized.

Copy link
Contributor Author

commented Nov 4, 2018

I'm running Brave 0.25.2 (8ea2a9c) which claims to be the latest, and the bug is still reproducible. But if there's a fix upstream that just needs to come out in a release, that's good. If there's no upstream fix on the way, I'd argue that this might be worth a mitigation in PeerTube, which is why I filed the bug here.

@Nutomic

This comment has been minimized.

Copy link
Contributor

commented Nov 4, 2018

First of all you should comment on the Brave issue, or contact them because the issue is on their side. It should be really easy to fix for them.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.