Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unable to subscribe to a channel from Pleroma #1383

Open
lord-re opened this Issue Nov 7, 2018 · 11 comments

Comments

Projects
None yet
5 participants
@lord-re
Copy link

lord-re commented Nov 7, 2018

What happened?
From Pleroma when you try to follow a channel you are forever waiting : "pending request"

What do you expect to happen instead?
It should be accepted (by probably returning a valid Accept activity back).

Steps to reproduce:

  1. Send a follow request to any peertube channel

Additional information

  • PeerTube version or URL: Every Peertube instances i tested act the same
    It works well with a mastodon account.
@Chocobozzz

This comment has been minimized.

Copy link
Owner

Chocobozzz commented Nov 13, 2018

It should be accepted (by probably returning a valid Accept activity back).

Are you sure we don't return an Accept? Because following a channel seems to work on Mastodon, and from the code I can see we send back the Accept: https://github.com/Chocobozzz/PeerTube/blob/develop/server/lib/activitypub/process/process-follow.ts#L55

@lord-re

This comment has been minimized.

Copy link
Author

lord-re commented Nov 13, 2018

I created an isuse on pleroma's bug tracker and that's what i've been told : https://git.pleroma.social/pleroma/pleroma/issues/364

@Chocobozzz

This comment has been minimized.

Copy link
Owner

Chocobozzz commented Nov 16, 2018

@lord-re Does it work if you try to follow a peertube account?

@Chocobozzz

This comment has been minimized.

Copy link
Owner

Chocobozzz commented Dec 11, 2018

@lord-re

This comment has been minimized.

Copy link
Author

lord-re commented Dec 11, 2018

I have the same behavior. In my logs i see that i'm sending the request but no answer then :

17:38:47.259 request_id=2lnl9cs7dncbhaat10000063 [info] POST /api/friendships/create.json
17:38:47.323 [info] Relaying https://pleroma.lord.re/activities/6af80923-66c4-437c-8039-ea64a34d77ac out
17:38:47.323 [info] Sending https://pleroma.lord.re/activities/6af80923-66c4-437c-8039-ea64a34d77ac out via AP
17:38:47.327 [info] Federating https://pleroma.lord.re/activities/6af80923-66c4-437c-8039-ea64a34d77ac to https://framatube.org/inbox
@Chocobozzz

This comment has been minimized.

Copy link
Owner

Chocobozzz commented Dec 11, 2018

Thanks. I was able to check the logs.

It seems Pleroma does not sign the Date header in http signature, which is mandatory for PeerTube.

@DeadSuperHero

This comment has been minimized.

Copy link

DeadSuperHero commented Feb 21, 2019

@Chocobozzz Date headers in http signatures are now signed: https://git.pleroma.social/pleroma/pleroma/merge_requests/847

local_videos_-_deadsuperhero_video

After some testing, I was able to generate a follow notification from Pleroma to PeerTube, but the Pleroma end still says that the request is awaiting approval.

Edit: This is what my journalctl output was:

 Feb 21 18:39:22.393 request_id=2m2na47l7hffpa480c0083d1 [info] POST /api/friendships/create.json
Feb 21 18:39:22 deadsuperhero mix[24967]: 18:39:22.404 [info] Relaying https://social.deadsuperhero.com/activities/c3906a3e-1179-4e8d-a452-36a901335e78 out
Feb 21 18:39:22 deadsuperhero mix[24967]: 18:39:22.404 [info] Sending https://social.deadsuperhero.com/activities/c3906a3e-1179-4e8d-a452-36a901335e78 out via AP
Feb 21 18:39:22 deadsuperhero mix[24967]: 18:39:22.414 [info] Federating https://social.deadsuperhero.com/activities/c3906a3e-1179-4e8d-a452-36a901335e78 to https://vidcommons.org/inbox
Feb 21 18:39:22 deadsuperhero mix[24967]: 18:39:22.561 request_id=2m2na47v7u2d8blg0c0083e1 [info] POST /users/sean/inbox
Feb 21 18:39:22 deadsuperhero mix[24967]: 18:39:22.562 request_id=2m2na47v7u2d8blg0c0083e1 [info] Sent 200 in 1ms
@Chocobozzz

This comment has been minimized.

Copy link
Owner

Chocobozzz commented Feb 22, 2019

@DeadSuperHero Send it to root@peertube3.cpy.re so I can check the logs

@DeadSuperHero

This comment has been minimized.

Copy link

DeadSuperHero commented Feb 22, 2019

@Chocobozzz done! Follow request sent from sean@social.deadsuperhero.com

@Chocobozzz

This comment has been minimized.

Copy link
Owner

Chocobozzz commented Feb 23, 2019

The accept was sent by peertube at Feb 22, 2019, 5:57:27 PM (UTC+1):

{
  "uri": "https://social.deadsuperhero.com/users/sean/inbox",
  "signatureActorId": 2,
  "body": {
    "type": "Accept",
    "id": "https://social.deadsuperhero.com/users/sean/accepts/follows/2",
    "actor": "https://peertube3.cpy.re/accounts/root",
    "object": {
      "type": "Follow",
      "id": "https://social.deadsuperhero.com/users/sean/follows/2",
      "actor": "https://social.deadsuperhero.com/users/sean",
      "object": "https://peertube3.cpy.re/accounts/root"
    }
  }
}

Do you have something in your logs at this time?

@buoyantair

This comment has been minimized.

Copy link
Contributor

buoyantair commented Mar 1, 2019

I have also not been able to subscribe to a lot of peertube channels just because I am using Plemora. Although I don't have anything else to add to this conversion but that when I click subscribe, it attempts to redirect me to plemora (permissions page I assume), and then nothing happens.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.
You signed in with another tab or window. Reload to refresh your session. You signed out in another tab or window. Reload to refresh your session.