Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Search filter bug with language preferences #2186

Closed
popindavibe opened this issue Oct 18, 2019 · 1 comment

Comments

@popindavibe
Copy link

@popindavibe popindavibe commented Oct 18, 2019

What happened?
When I am signed in, my language preferences are enforced when searching videos, and the filter bar shows 1 filter active.
For unknown reason, this gives me 0 results (testing with facebook search, which I checked, does have videos marked with my language preferences).
If I select blank in the Language search filter and search again, this removes all filters and I am getting appropriate search results.

Incidentally, if I run another search again, my language preferences filter comes back and again no results. This is not a bug or an issue as such, but it may be nice to keep you last search filter somewhere in cache with a way to quickly reset the search filters than resetting on every new search.

What do you expect to happen instead?
It's good that the language preference is used for search, but it should give actual results.

Steps to reproduce:

  1. Sign in with a user and set language preferences to 2 or more languages

  2. Do a search on facebook, get no results
    ex: https://peertube.nomagic.uk/search?search=facebook&languageOneOf=fr&languageOneOf=en

  3. Expand the search filters and select 'Blank' or 'English' for language and search again: you get results
    ex: https://peertube.nomagic.uk/search?search=facebook&languageOneOf=en

Additional information

@Chocobozzz

This comment has been minimized.

Copy link
Owner

@Chocobozzz Chocobozzz commented Oct 21, 2019

Thanks for the issue. It should be fixed by baeb429

@Chocobozzz Chocobozzz closed this Oct 21, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.