Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add published date attribute to video #234

Closed
Chocobozzz opened this issue Jan 23, 2018 · 3 comments
Closed

Add published date attribute to video #234

Chocobozzz opened this issue Jan 23, 2018 · 3 comments

Comments

@Chocobozzz
Copy link
Owner

@Chocobozzz Chocobozzz commented Jan 23, 2018

It's more useful for users to see when a video was published (privacy set to unlisted/public) than when it was created.

  • Add a publishedAt video attribute in database
  • Create a migration script that set publishedAt = createdAt for old videos (need to update the LAST_MIGRATION_VERSION in constants.ts
  • Set publishedAt = NOW when the video becomes public/unlisted (on upload/update)
  • Add this attribute in VideoTorrentObject for ActivityPub
  • Add this new field when sending the video to followers
  • Parse this new field when receiving a new video
  • Display publishedAt attribute instead of createdAt on the client interface (except in the My Account -> My videos panel)
  • (Optional) Update tests (I can do it)
@jlebras

This comment has been minimized.

Copy link
Contributor

@jlebras jlebras commented Mar 27, 2018

Hello, I would like to contribute to this issue if no one has already started working on it.
(Actually, I'm already working on it, try to stop me :D)

The VideoTorrentObject has already a published attribute which seems to hold the ISOString of the createdAt field. Should I reuse this attribute to avoid confusion or are they 2 distinct things ?

@Chocobozzz

This comment has been minimized.

Copy link
Owner Author

@Chocobozzz Chocobozzz commented Mar 28, 2018

Yep, reuse this attribute to use the publishedAt video instead of createdAt. With the new attribute publishedAt we will not use createdAt anymore

@rigelk

This comment has been minimized.

Copy link
Collaborator

@rigelk rigelk commented Mar 30, 2018

Implemented in #439 - thanks @jlebras !

@rigelk rigelk closed this Apr 20, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
3 participants
You can’t perform that action at this time.