Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HLS experimental support #1566

Merged
merged 8 commits into from Feb 11, 2019

Conversation

Projects
None yet
4 participants
@Chocobozzz
Copy link
Owner

commented Jan 24, 2019

@Chocobozzz Chocobozzz changed the title WIP: Feature/refractor player WIP: HLS experimental support Jan 30, 2019

@Chocobozzz Chocobozzz force-pushed the feature/refractor-player branch 5 times, most recently from 8ca84b8 to 0dac636 Jan 31, 2019

@mrlika

This comment has been minimized.

Copy link

commented Feb 5, 2019

Why do you use videojs? Is it used all over PeerTube?

P2P Media Loader support is not perfect in case of videojs because it does not use its build in HTTP streaming plugin but relies on a custom plugin that provides hlsjs engine support in the player. And the plugin is not actively developed.

@rigelk

This comment has been minimized.

Copy link
Collaborator

commented Feb 5, 2019

@mrlika yes, that's the current video player in use

@mrlika

This comment has been minimized.

Copy link

commented Feb 5, 2019

Ok. I will try to add videojs HTTP streaming support for P2P Media Loader in nearest future.

@rigelk

This comment has been minimized.

Copy link
Collaborator

commented Feb 5, 2019

@mrlika 😲 that would be more than welcome ! Thanks

@Chocobozzz

This comment has been minimized.

Copy link
Owner Author

commented Feb 6, 2019

Why do you use videojs? Is it used all over PeerTube?

@mrlika In fact we use videojs-core (so without the streaming parts) with hls.js library using https://github.com/streamroot/videojs-hlsjs-plugin and it seems to work pretty well!

Chocobozzz added some commits Jan 23, 2019

Refractor videojs player
Add fake p2p-media-loader plugin

@Chocobozzz Chocobozzz force-pushed the feature/refractor-player branch from 0dac636 to 4429c04 Feb 7, 2019

@Chocobozzz Chocobozzz changed the title WIP: HLS experimental support HLS experimental support Feb 7, 2019

@tcitworld

This comment has been minimized.

Copy link
Collaborator

commented on c36abf7 Feb 8, 2019

Is this related to this PR ? :)

This comment has been minimized.

Copy link
Owner Author

replied Feb 9, 2019

Yep because we still had import * as WebTorrent from 'webtorrent' in the watch component (we should lazy load it in the webtorrent plugin instead).

@Chocobozzz Chocobozzz merged commit c7ca4c8 into develop Feb 11, 2019

3 of 4 checks passed

continuous-integration/travis-ci/pr The Travis CI build could not complete due to an error
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
security/snyk - client/package.json (Chocobozzz) No new issues
Details
security/snyk - package.json (Chocobozzz) No new issues
Details
@tcitworld

This comment has been minimized.

Copy link
Collaborator

commented Feb 11, 2019

🎉

@Chocobozzz Chocobozzz deleted the feature/refractor-player branch Feb 11, 2019

@Chocobozzz

This comment has been minimized.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.