Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add simple subtitle edition from video captions tab #4666

Merged

Conversation

lutangar
Copy link
Contributor

@lutangar lutangar commented Dec 22, 2021

Description

Introduce a new Edit button on a subtitle.
It opens a modal with simple textarea allowing the user to do quick corrections
on a subtitle.

Related issues

#1481

Has this been tested?

  • 馃憤 yes, I added tests to the test suite
  • 馃挱 no, because this PR is a draft and still needs work
  • 馃檯 no, because this PR does not update server code
  • 馃檵 no, because I need help

Screenshots

@rigelk rigelk linked an issue Dec 27, 2021 that may be closed by this pull request
@lutangar lutangar force-pushed the feature/caption-edition branch 3 times, most recently from cf2586c to 19a6b5a Compare February 3, 2022 17:33
@lutangar lutangar marked this pull request as ready for review February 3, 2022 18:01
@lutangar lutangar changed the title WIP Add simple subtitle edition from video captions tab Add simple subtitle edition from video captions tab Feb 3, 2022
@lutangar lutangar force-pushed the feature/caption-edition branch 2 times, most recently from 91ca8a5 to 1fa71c1 Compare February 4, 2022 13:20
lutangar and others added 2 commits February 28, 2022 13:45
Introduce a new __Edit__ button on a subtitle.
It opens a modal with simple textarea allowing the user to do quick corrections on a subtitle.
@Chocobozzz Chocobozzz merged commit 70a8e50 into Chocobozzz:develop Feb 28, 2022
@lutangar
Copy link
Contributor Author

馃帀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Allow adding and editing subtitles inside Peertube
2 participants