Skip to content
This repository
Browse code

Revert "wrapper: provisional 10.7 "Lion" support"

A user has reported kernel panics (!) with possible associations
with tmux and the wrapper.

    https://sourceforge.net/mailarchive/message.php?msg_id=27834727

Go back to warning on 10.7 until I hear some better-sounding reports
(or get some first-hand experience with Lion)..

This reverts commit 8c5ea5f.
  • Loading branch information...
commit 51bbc9fb2048ca3fa3c625cfebce216ecaae86dc 1 parent 8c5ea5f
Chris Johnsen authored

Showing 1 changed file with 5 additions and 6 deletions. Show diff stats Hide diff stats

  1. 11  reattach-to-user-namespace.c
11  reattach-to-user-namespace.c
@@ -41,7 +41,7 @@
41 41
 #include "msg.h"
42 42
 
43 43
 #if 0
44  
-void * _vprocmgr_move_subset_to_user(uid_t target_user, const char *session_type, uint64_t flags); /* 10.6, 10.7 */
  44
+void * _vprocmgr_move_subset_to_user(uid_t target_user, const char *session_type, uint64_t flags); /* 10.6 */
45 45
 void * _vprocmgr_move_subset_to_user(uid_t target_user, const char *session_type); /* 10.5 */
46 46
 #endif
47 47
 
@@ -82,15 +82,14 @@ int main(int argc, char *argv[]) {
82 82
     if (os < 1050) {
83 83
         warn("unsupported old OS, trying as if it were 10.5");
84 84
         os = 1050;
85  
-    } else if (os > 1070) {
86  
-        warn("unsupported new OS, trying as if it were 10.7");
87  
-        os = 1070;
  85
+    } else if (os > 1060) {
  86
+        warn("unsupported new OS, trying as if it were 10.6");
  87
+        os = 1060;
88 88
     }
89 89
 
90 90
     switch(os) {
91 91
         case 1050:
92 92
         case 1060:
93  
-        case 1070:
94 93
             {
95 94
                 static const char fn[] = "_vprocmgr_move_subset_to_user";
96 95
                 void *f;
@@ -110,7 +109,7 @@ int main(int argc, char *argv[]) {
110 109
                     void *(*func)(uid_t, const char *) = f;
111 110
                     r = func(getuid(), bg);
112 111
                 }
113  
-                else if (os == 1060 || os == 1070) {
  112
+                else if (os == 1060) {
114 113
                     void *(*func)(uid_t, const char *, uint64_t) = f;
115 114
                     r = func(getuid(), bg, 0);
116 115
                 } else

7 notes on commit 51bbc9f

Andreas Wålm

I've this patch on and it works great, no kernel panics.
I'm running tmux in iTerm.

Chris Johnsen
Owner

It is great to hear that! Thank you for the feedback.

I have been sitting on a patch that effectively re-does 8c5ea5f (with minor, internal changes), but I have not pushed it since the only feedback I had received so far was the email linked in the commit message that involves kernel panics.

I was hoping that the “unsupported new OS” warning message would stir up some more feedback, but that has not quite worked out.

If you know anyone else using this wrapper with tmux under Lion, you might encourage them to ping me with their feedback (especially if they use it under Terminal, since it is possible the panics (if they are not specific to the user that reported them) might arise from tmux under Terminal). If I get enough Lion feedback, I will feel more comfortable about pushing a commit that silences the warning under Lion.

Chris Hoffman

I haven't used it under Terminal yet, but I too have been using this under iTerm with tmux without any issues. Been this way since the day Lion was official.

Ruben Fonseca

I've been using the "old" 10.6 method on Lion since GM, and it works flawlessly, as in 10.6. No problem with the 10.6 method on Lion whatsoever.

Chris Johnsen
Owner

@rubenfonseca: Thanks for the feedback! Have you been using the built-in Terminal application or a third party emulator?

Ruben Fonseca

@ChrisJohnsen I've been using iTerm2 only. Had no idea that was relevant!

Chris Johnsen
Owner

@rubenfonseca: Frankly, I would not usually consider the particular terminal emulator to be relevant to the situation, but the reported kernel panics (in the email thread linked in the commit message for 51bbc9f) have put me in a doubting frame of mind.

The spate of feedback on this commit has only been from users of iTerm or iTerm2, so I am still looking to hear whether Lion + Terminal + tmux + this wrapper is a problematic combination.

Please sign in to comment.
Something went wrong with that request. Please try again.