Skip to content
Browse files

wrapper: preliminary 10.8 "Lion" support

Update the wrapper code to not issue a warning about an "unsupported
new OS" when run on Mountain Lion.

This may not even be appropriate. I have not used Mountain Lion or
heard from anyone that has.

Assuming 10.8 works like 10.6-10.7, this should be enough to squelch
the warning. This commit will be rewritten (at least to edit this
commit message) once some evidence comes in as to whether this is
appropriate (i.e. probably after a public release of 10.8 and the
release of the open source bits -- especially the launchd source
where the relevant function is defined).
  • Loading branch information...
1 parent dadea0a commit f4a2901bb2b4c29a36e3ec0601219d384c5d24e3 @ChrisJohnsen committed
Showing with 3 additions and 2 deletions.
  1. +3 −2 reattach-to-user-namespace.c
View
5 reattach-to-user-namespace.c
@@ -87,15 +87,16 @@ int main(int argc, char *argv[]) {
* 10.5 => 1050
* 10.6 => 1060
* 10.7 => 1060
+ * 10.8 => 1060
* > 10.7 => 1060 with warning
*/
- if (1060 <= os && os <= 1070)
+ if (1060 <= os && os <= 1080)
os = 1060;
else if (os < 1050) {
warn("unsupported old OS, trying as if it were 10.5");
os = 1050;
} else if (os > 1060) {
- warn("unsupported new OS, trying as if it were 10.6-10.7");
+ warn("unsupported new OS, trying as if it were 10.6-10.8");
os = 1060;
}

2 comments on commit f4a2901

@gvvaughan

Hi Chris,

I'm currently running the Mountain Lion Gold Master (10.8 Build 12A269), with my brew based /usr/local updated to the latest version of tmux (1.6).

I haven't looked at any launchd sources, but I can confirm that my environment still exhibits a broken pbcopy without any reattach workarounds, and that using a version of reattach-to-user-namespace built from this git revision fixes it, exactly as it did with Lion.

Thanks for your work on this btw, I've been using it happily for well over a year now.

@ChrisJohnsen

@gvvaughan

Gary,

Thank you for the thorough feedback!
Hearing the details of your environment and that you tested both with and without the wrapper is so much better than a plain “works for me”.

Please sign in to comment.
Something went wrong with that request. Please try again.