make error #2

Merged
merged 3 commits into from Jun 26, 2011

Projects

None yet

2 participants

@trevor
Contributor
trevor commented Jun 25, 2011

i was getting a minor error in make, here's a weak fix.

this works great, thank you!

trevor added some commits Jun 25, 2011
@trevor trevor resolve make error when llvm doesn't have powerpc
% make
cc -Wall -Wextra -ansi -pendantic -arch i386 -arch ppc -arch x86_64 -mmacosx-version-min=10.5   -c -o test.o test.c
llvm-gcc-4.2: error trying to exec '/usr/bin/../llvm-gcc-4.2/bin/powerpc-apple-darwin10-llvm-gcc-4.2': execvp: No such file or directory
lipo: can't figure out the architecture type of: /var/folders/MT/MTdESo89GBCaGM7Hevp5+E+++TI/-Tmp-//ccG0JJrt.out
make: *** [test.o] Error 255
6fdf4be
@trevor trevor minor doc styling ce5ed9b
@trevor trevor minor doc styling 149acd9
@ChrisJohnsen ChrisJohnsen merged commit 149acd9 into ChrisJohnsen:master Jun 26, 2011
@ChrisJohnsen
Owner

Thank you for the feedback and commits.

Dropping PPC as a default architecture is reasonable.

The Markdown rendering issue did not show up in my local renders, but it definitely fixes things for GitHub’s rendering (I never noticed it, since I assumed that my local rdiscount-based render would match GitHub’s).

I added a commit on top to include some text before the mention of kill-server to make sure that a casual reader would not think that the command would simply restart their tmux server.

@ChrisJohnsen ChrisJohnsen was assigned Jun 26, 2011
@trevor
Contributor
trevor commented Jun 26, 2011

hi Chris,

happy to help. i was surprised about the minor markdown issue as well, but it seems like there's a lot of variation of implementations out there. if you're interested:

github uses their own implementation called upskirt, which they wrap with redcarpet

rdiscount README.md > readme_rdiscount_render_bin.html
redcarpet README.md > readme_redcarpet_render_bin.html
ruby -rrdiscount -e "print RDiscount.new(IO.read('README.md')).to_html" > readme_rdiscount_render.html
ruby -rredcarpet -e "print Redcarpet.new(IO.read('README.md')).to_html" > readme_redcarpet_render.html
ruby -rredcarpet -e "print RedcarpetCompat.new(IO.read('README.md')).to_html" > readme_redcarpet_rdiscount_render.html
@ChrisJohnsen
Owner

Thanks for pointing out redcarpet.

I added it to my local rendering script and used it to find and fix one actual and one potential problem in README.md.

@ChrisJohnsen ChrisJohnsen added a commit that referenced this pull request Jul 30, 2012
@ChrisJohnsen wrapper: account for -l when checking argc
If "-l" is the first argument, record the fact in a variable and
adjust argv and argc as if had not been present. This lets the
existing "minimum arguments" check to handle the case where "-l" is
the only argument.

Previously, if "-l" was the only argument, we would end up with
a segmentation fault from accidentally doing strlen(argv[argc])
(i.e. strlen(NULL)) in the dash-prefixing code.

Reported as item #2 here:

    #13
907f222
@ChrisJohnsen ChrisJohnsen added a commit that referenced this pull request Jul 30, 2012
@ChrisJohnsen wrapper: account for -l when checking argc
If "-l" is the first argument, record the fact in a variable and
adjust argv and argc as if had not been present. This lets the
existing "minimum arguments" check to handle the case where "-l" is
the only argument.

Previously, if "-l" was the only argument, we would end up with
a segmentation fault from accidentally doing strlen(argv[argc])
(i.e. strlen(NULL)) in the dash-prefixing code.

Reported as item #2 here:

    #13
66ffbee
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment