Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[TS] LPS-112246 Permission setting with new top level PanelCategory #213

Closed
wants to merge 2 commits into from
Closed

[TS] LPS-112246 Permission setting with new top level PanelCategory #213

wants to merge 2 commits into from

Conversation

NorbertKocsis
Copy link

@liferay-continuous-integration
Copy link
Collaborator

To conserve resources, the PR Tester does not automatically run for every pull.

If your code changes were already tested in another pull, reference that pull in this pull so the test results can be analyzed.

If your pull was never tested, comment "ci:test" to run the PR Tester for this pull.

@NorbertKocsis
Copy link
Author

ci:test:relevant

@liferay-continuous-integration
Copy link
Collaborator

✔️ ci:test:stable - 18 out of 18 jobs passed

✔️ ci:test:relevant - 40 out of 40 jobs passed in 1 hour 29 minutes 1 second 284 ms

Click here for more details.

Base Branch:

Branch Name: master
Branch GIT ID: 620887c4b57b1ae75673102707a3e6e6d1329135

Copied in Private Modules Branch:

Branch Name: master-private
Branch GIT ID: b4536024712dac54820c4c13f7cf737b2b7a945b

ci:test:stable - 18 out of 18 jobs PASSED
18 Successful Jobs:
ci:test:relevant - 40 out of 40 jobs PASSED
40 Successful Jobs:
For more details click here.

@ChrisKian
Copy link
Owner

Hey @NorbertKocsis,
This change is good, however I'd like one small change. If there are no apps under "Other", could we please remove the entire tab?
Before I deployed the sample portlet from LPP-37037, the category for "Other" had no entries, which was confusing.

Aside from that, the only other thing is to not run ci test relevant on the PR sent to me. I am not in engineering, so I won't forward to BChan directly.

I will close this PR now, and await your amendment, thanks!

@ChrisKian ChrisKian closed this Apr 29, 2020
@IstvanD IstvanD mentioned this pull request Nov 19, 2020
Closed
@ChrisKian ChrisKian mentioned this pull request Nov 20, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
ci:test:relevant - success ci:test:stable - success
Projects
None yet
Milestone
No milestone
3 participants
@NorbertKocsis @liferay-continuous-integration @ChrisKian