Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

In n_gram_merge(), issues when arg bus_suffix = FALSE and ignore_strings is non_NULL #7

Closed
ChrisMuir opened this issue Mar 21, 2018 · 0 comments

Comments

@ChrisMuir
Copy link
Owner

In n_gram_merge(), getting incorrect output when arg bus_suffix is set to FALSE and a char vector is passed to arg ignore_strings. Here's an example:

vect <- c("cats, inc", "cats, incorporated", "cats, llc")
refinr::n_gram_merge(vect, bus_suffix = FALSE, ignore_strings = "dogs")
#> [1] "cats, inc" "cats, inc" "cats, llc"

The intended output is that none of the input values should have been merged together. Currently, if bus_suffix = FALSE and ignore_strings is not NULL, within refinr:::get_fingerprint_ngram(), vect is being run through business_suffix() (this should not be happening) .... this is causing the issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant