Updated node-inspector and other deps #25
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Could you update the test string to make it pass and not bump the version number? I will bump package.json version when I release. Thanks for the PR! |
|
I couldn't get the test to pass at all, even using the code currently on master. So I don't really know what to do here. |
Looks like the output from node-inspector has changed and the assertion has to be updated. |
|
D'oh - of course. Sorry about that, should be fixed now. |
ChrisWren
added a commit
that referenced
this pull request
May 1, 2015
Updated node-inspector and other deps
|
Thank you sir! |
|
Thanks for the speedy merge! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I couldn't get the test to pass, but it wouldn't pass even before making these changes.