Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve URL creation. #1

Open
ChristianAlexander opened this issue Sep 2, 2017 · 0 comments
Open

Improve URL creation. #1

ChristianAlexander opened this issue Sep 2, 2017 · 0 comments
Labels

Comments

@ChristianAlexander
Copy link
Owner

@ChristianAlexander ChristianAlexander commented Sep 2, 2017

After shipping in Heroku, a hack was added to allow a production build to force HTTPS on the generated URLs that are returned when mapping from the repository to the JSON response. This is because Heroku's load balancers terminate SSL/TLS and hit applications directly using HTTP.

This hack introduced two undesirable changes:

  1. A new environment variable was added, which should not be necessary.
  2. The Request object is directly modified to have IsHttps = true.

A possible solution is to modify the incoming request using some middleware, possibly after detecting the standard ASPNETCORE_ENVIRONMENT variable.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
1 participant