Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added link in developing with dev tools #103

Merged

Conversation

@crislin2046
Copy link
Contributor

crislin2046 commented Nov 11, 2019

I don't think you'll merge this PR because it looks like it's just promoting a commercial product.

I made a 'remote browser isolation' platform and share this free demo of it here.

I heavily rely on Chrome devtools for this task so want to give back to the community by showing what's possible.

As I'm unwilling to release the source (because the full product is money-making) I'm quite sure you'll be unable to include it here.

I don't think you'll merge this PR because it looks like it's just promoting a commercial product.

I made a 'remote browser isolation' platform and share this free demo of it here. 

I heavily rely on Chrome devtools for this task so want to give back to the community by showing what's possible.

As I'm unwilling to release the source (because the full product is money-making) I'm quite sure you'll be unable to include it here.
@googlebot

This comment has been minimized.

Copy link

googlebot commented Nov 11, 2019

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

@crislin2046

This comment has been minimized.

Copy link
Contributor Author

crislin2046 commented Nov 11, 2019

@googlebot I signed it!

@googlebot

This comment has been minimized.

Copy link

googlebot commented Nov 11, 2019

CLAs look good, thanks!

ℹ️ Googlers: Go here for more info.

@Garbee

This comment has been minimized.

Copy link
Collaborator

Garbee commented Nov 13, 2019

I'll look in getting our contributing file updated to reflect our stance on this properly. My current understanding is that you are correct, we don't accept things that are free demos or paid services. The goal is to promote projects that others may use to better use the DevTools and learn how to work on the provided APIs in their own projects.

Unless something has changed in this regard (which we'll figure out shortly enough with my PR to the contributing file) this won't be pulled in. Closing this out for now and if we come to another decision after that discussion then we can re-open and merge.

Thank you.

@Garbee Garbee closed this Nov 13, 2019
@crislin2046

This comment has been minimized.

Copy link
Contributor Author

crislin2046 commented Nov 13, 2019

Understood. Thanks for the thorough explanation @Garbee

@crislin2046

This comment has been minimized.

Copy link
Contributor Author

crislin2046 commented Nov 18, 2019

Can I re-open, @Garbee ?

Because it's now Open Sourced:

https://github.com/dosycorp/browsergap.ce

@Garbee

This comment has been minimized.

Copy link
Collaborator

Garbee commented Nov 18, 2019

I don't see why not now. Although I would say based on the current state of things I'd prefer a link to the github repo over the site directly since it doesn't seem to be updated to reference that. While the repo does link to the service that is online.

@Garbee Garbee reopened this Nov 18, 2019
@crislin2046

This comment has been minimized.

Copy link
Contributor Author

crislin2046 commented Nov 18, 2019

Sorry, that's what I meant. A link to the GitHub repo!

crislin2046 added 2 commits Nov 18, 2019
Also hopefully trigger the CI build to pass this time (checked error details for previous commit's build fail and Travis said, "API quota exceeded").
@crislin2046

This comment has been minimized.

Copy link
Contributor Author

crislin2046 commented Nov 19, 2019

Hey @Garbee does this not LGTY?

@Garbee

This comment has been minimized.

Copy link
Collaborator

Garbee commented Nov 20, 2019

With that last text update it does. Sorry for delay, meant to comment the other day about that when I saw this in my notifications but work got overwhelming.

@Garbee Garbee merged commit 2648d9b into ChromeDevTools:master Nov 20, 2019
2 checks passed
2 checks passed
cla/google All necessary CLAs are signed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@crislin2046

This comment has been minimized.

Copy link
Contributor Author

crislin2046 commented Nov 20, 2019

Thanks @Garbee !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.