Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add link to Rust crate #90

Merged
merged 2 commits into from Feb 17, 2019

Conversation

@atroche
Copy link
Contributor

commented Feb 14, 2019

Thanks!

@googlebot

This comment has been minimized.

Copy link

commented Feb 14, 2019

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here (e.g. I signed it!) and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers
@atroche

This comment has been minimized.

Copy link
Contributor Author

commented Feb 14, 2019

I signed it!

@googlebot

This comment has been minimized.

Copy link

commented Feb 14, 2019

CLAs look good, thanks!

@Garbee

This comment has been minimized.

Copy link
Collaborator

commented Feb 17, 2019

I would like to see a more descriptive expression of the package. Rather than "A rust crate for the protocol" could we try to have something more like, "An implementation of puppeteer in Rust". Something along these lines is more descriptive of what readers can expect when they click through. Especially since it defines the protocol being replicated when we have multiple protocols for Chrome and the DevTools.

Improve description of Rust Headless Chrome link
"An implementation of Puppeteer in Rust"
@atroche

This comment has been minimized.

Copy link
Contributor Author

commented Feb 17, 2019

@Garbee thanks, how's that?

@Garbee

This comment has been minimized.

Copy link
Collaborator

commented Feb 17, 2019

Looks good to me, thank you.

@Garbee Garbee merged commit aefc760 into ChromeDevTools:master Feb 17, 2019

1 of 2 checks passed

continuous-integration/travis-ci/pr The Travis CI build failed
Details
cla/google All necessary CLAs are signed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.