Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Updating the ListItem layout to use CL #10

Merged
merged 4 commits into from
Nov 12, 2018
Merged

Updating the ListItem layout to use CL #10

merged 4 commits into from
Nov 12, 2018

Conversation

cortinico
Copy link
Member

I've refactored a bit the layout of the list items:

  • Now uses a ConstraintLayout instead of a RelativeLayout (+ nested layouts)
  • Time TextView had a static size and was wrapping the line on my device (annyoing and causing extra space to be used).
  • Fixed the alignment so now the list will look more "ordered"
  • Added color for the SSL icon
  • Updated IDs to have chucker_ as a prefix

Regarding the last point, we should probably do it for all the ids otherwise will create a mess on IDs of client projects

@cortinico
Copy link
Member Author

Old:
screenshot_1541865175

New:
screenshot_1541934524

olivierperez
olivierperez requested changes Nov 12, 2018
View reviewed changes
Copy link
Member

@olivierperez olivierperez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Two comments on layout.

library/src/main/res/layout/chucker_list_item_transaction.xml Outdated Show resolved Hide resolved
library/src/main/res/layout/chucker_list_item_transaction.xml Show resolved Hide resolved
@cortinico
Copy link
Member Author

@olivierperez now should be ready to go

@cortinico
Copy link
Member Author

Rebased on top of develop

@olivierperez olivierperez merged commit 24a7f8a into develop Nov 12, 2018
@cortinico cortinico deleted the items-layout-to-constraint branch November 26, 2018 12:37
@cortinico cortinico added this to the 3.0.0 milestone Aug 8, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@olivierperez olivierperez olivierperez approved these changes

Assignees

@cortinico cortinico

Labels
None yet
Projects
None yet
Milestone
3.0.0
Development

Successfully merging this pull request may close these issues.
2 participants
@cortinico @olivierperez