Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updating the ListItem layout to use CL #10

Merged
merged 4 commits into from Nov 12, 2018

Conversation

@cortinico
Copy link
Contributor

commented Nov 11, 2018

I've refactored a bit the layout of the list items:

  • Now uses a ConstraintLayout instead of a RelativeLayout (+ nested layouts)
  • Time TextView had a static size and was wrapping the line on my device (annyoing and causing extra space to be used).
  • Fixed the alignment so now the list will look more "ordered"
  • Added color for the SSL icon
  • Updated IDs to have chucker_ as a prefix

Regarding the last point, we should probably do it for all the ids otherwise will create a mess on IDs of client projects

@cortinico cortinico requested a review from olivierperez Nov 11, 2018

@cortinico

This comment has been minimized.

Copy link
Contributor Author

commented Nov 11, 2018

Old:
screenshot_1541865175

New:
screenshot_1541934524

@olivierperez
Copy link
Member

left a comment

Two comments on layout.

@cortinico

This comment has been minimized.

Copy link
Contributor Author

commented Nov 12, 2018

@olivierperez now should be ready to go

@cortinico cortinico force-pushed the items-layout-to-constraint branch from 7019443 to bdaccbf Nov 12, 2018

@cortinico

This comment has been minimized.

Copy link
Contributor Author

commented Nov 12, 2018

Rebased on top of develop

@olivierperez olivierperez merged commit 24a7f8a into develop Nov 12, 2018

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details

@cortinico cortinico deleted the items-layout-to-constraint branch Nov 26, 2018

@cortinico cortinico added this to the 3.0.0 milestone Aug 8, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.