Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pass the -module-name Kotlin Compiler flag #146

Merged
merged 1 commit into from Dec 30, 2019
Merged

Conversation

@cortinico
Copy link
Member

cortinico commented Oct 23, 2019

Attempt to fix #134 by passing a compiler flag to prevent name clashing with the META-INF/library_release.kotlin_module filename.

Fixes #134

馃摑 Changes

Adding a Kotlin compiler flag inside both library and library-no-op.

鈿狅笍 Breaking

Nop

馃摑 How to test

Ideally we could publish the artifact locally and check that the file is properly named inside the Jar

Fixes #134
@cortinico cortinico added the bug label Oct 23, 2019
@cortinico cortinico added this to the 3.1.0 milestone Oct 23, 2019
@cortinico cortinico requested a review from redwarp Oct 23, 2019
@cortinico cortinico self-assigned this Oct 23, 2019
@cortinico cortinico merged commit a45ffec into develop Dec 30, 2019
2 checks passed
2 checks passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
@cortinico cortinico deleted the fix-clashing-module-name branch Dec 30, 2019
kmayoral added a commit to kmayoral/chucker that referenced this pull request Jan 21, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

1 participant
You can鈥檛 perform that action at this time.