Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cannot add selected group members to cart #2474

Closed
chiebert opened this issue May 4, 2017 · 0 comments · Fixed by #2481
Closed

Cannot add selected group members to cart #2474

chiebert opened this issue May 4, 2017 · 0 comments · Fixed by #2481
Assignees
@crossan007
Labels
Feature: Groups
Milestone
2.9.0

Comments

@chiebert
Copy link
Contributor

chiebert commented May 4, 2017 •
edited by crossan007

Just upgraded to 2.7.5, and have noticed that I cannot add selected members of a group to the cart. By this I mean, if I select one or more members of a group (by clicking on them to highlight them), both the 'remove member from group' and 'add selected members to cart' buttons are disabled (cursor gets a disabled overlay, and buttons do not respond). I can still 'add all group members to cart' at the top of the page.
@crossan007 crossan007 mentioned this issue May 4, 2017
Closed
@crossan007 crossan007 self-assigned this May 6, 2017
crossan007 added a commit that referenced this issue May 6, 2017
@crossan007
closes #2474
3857674
@crossan007 crossan007 mentioned this issue May 6, 2017
Closed
@ghost ghost added In Review and removed bug labels May 6, 2017
This was referenced May 6, 2017
Closed
Merged
@crossan007 crossan007 modified the milestone: Backlog Jul 14, 2017
@DawoudIO DawoudIO modified the milestones: Backlog, 2.9.0 Nov 18, 2017
@ghost ghost removed the In Review label Nov 27, 2017
crossan007 added a commit that referenced this issue Nov 27, 2017
@crossan007
Improve Cart - Use Client Side Code (#2481)
31e63a2 
* closes #2474

* cart as client-side code in progress

* empty to group works

* add group to cart - client side object model API

* Better cart view on SelectList page

* move AddToPeopleCart out of GET param into CRMJSOM

* start to move group/role selection to bootbox / CRMJSOM

* Empty cart to group via JSOM

* tweaks

* use JSOM

* update cart api

* moving between groups to JSOM (not done)

* Apply fixes from StyleCI

* Move cart menu to JS. cleanup JSOM.

* working group add / remove

* cleanup

* working move members between groups

* Cart DTO

* underp dto

* more dto

* dead code

* cart dto

* dto / api

* working empty to group w/ role

* remove CartToGroup.php with JSOM

* underp personView Add to CArt

* dto

* fix test

* fix tests

* Apply fixes from StyleCI (#2927)

* fix jsom methods

* Fixes

* Fixes

* Apply fixes from StyleCI

* prepare cart on page load

* cleanup and fix null logic error

* underp cart add/remove toggle

* fix cartview logic

* add cart code - no operational changes yet

* fix failing test

* Apply fixes from StyleCI

* fix empty to group

* fix cart to family

* tweaks to featurecontext bootstrap

* more tweaks

* tests

* fix last failing test

* cart add and empty tests now pass

* underp group view cart add

* add datatype input validation to cart dto
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@crossan007 crossan007

Labels
Feature: Groups
Projects
None yet
Milestone
2.9.0
Development

Successfully merging a pull request may close this issue.

Improve Cart - Use Client Side Code ChurchCRM/CRM
3 participants
@DawoudIO @chiebert @crossan007