Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Javascript is not scanned for new i18next.t() strings #2761

Closed
crossan007 opened this issue Jul 9, 2017 · 1 comment
Closed

Javascript is not scanned for new i18next.t() strings #2761

crossan007 opened this issue Jul 9, 2017 · 1 comment
Assignees
@crossan007
Labels
API Localization
Milestone
2.8.4

Comments

@crossan007
Copy link
Contributor

crossan007 commented Jul 9, 2017 •
edited

part of #964

The "locale-gen" npm task needs to also scan JS files for i18next.t() calls so that the string literals may be extracted and placed into the messages.po file for upload to POEditor.com

The download and on-page part is already complete.
@crossan007 crossan007 mentioned this issue Jul 9, 2017
Merged
@crossan007
Copy link
Contributor Author

trying this: https://www.npmjs.com/package/i18next-extract-gettext

@crossan007 crossan007 self-assigned this Jul 9, 2017
@crossan007 crossan007 mentioned this issue Jul 9, 2017
Closed
@ghost ghost added the In Review label Jul 9, 2017
@ghost ghost removed the In Review label Jul 10, 2017
@DawoudIO DawoudIO added this to the 2.8.4 milestone Jul 10, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@crossan007 crossan007

Labels
API Localization
Projects
None yet
Milestone
2.8.4
Development

Successfully merging a pull request may close this issue.

Scan JS files during locale-gen npm task ChurchCRM/CRM
2 participants
@DawoudIO @crossan007