Skip to content

Json config parser for ConfigServiceProvider #7

Merged
merged 3 commits into from Apr 15, 2012

3 participants

@benmatselby

The ability to have a json configuration file parsed by the ConfigServiceProvider

@stof stof and 1 other commented on an outdated diff Apr 15, 2012
tests/Cilex/Tests/Provider/ConfigServerProviderTest.php
@@ -0,0 +1,101 @@
+<?php
+/**
+ * This file is part of the Cilex framework.
+ *
+ * (c) Mike van Riel <mike.vanriel@naenius.com>
+ *
+ * For the full copyright and license information, please view the LICENSE
+ * file that was distributed with this source code.
+ *
+ * @category Cilex
+ * @package Cilex
+ * @subpackage Tests
+ * @author Ben Selby <benmatselby@gmail.com>
@stof
Cilex member
stof added a note Apr 15, 2012

these tags have nothing to do in the license header. Their location is the phpdoc of the class

@benmatselby
benmatselby added a note Apr 15, 2012

Done

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
@stof stof and 1 other commented on an outdated diff Apr 15, 2012
tests/Cilex/Tests/Provider/ConfigServerProviderTest.php
+ * @package Cilex
+ * @subpackage Tests
+ * @author Ben Selby <benmatselby@gmail.com>
+ */
+
+namespace Cilex\Tests\Provider;
+
+use Cilex\Application;
+use Cilex\Provider\ConfigServiceProvider;
+
+/**
+ * Test file for ConfigServiceProvider
+ *
+ * @category Cilex
+ * @package Cilex
+ * @subpackage Tests
@stof
Cilex member
stof added a note Apr 15, 2012

you should remove @category @package and @subpackage.

@benmatselby
benmatselby added a note Apr 15, 2012

Done

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
@mvriel mvriel merged commit bdb34f0 into Cilex:master Apr 15, 2012
@mvriel
Cilex member
mvriel commented Apr 15, 2012

Great addition, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Something went wrong with that request. Please try again.