Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: arguments support for aws deploy #140

Merged

Conversation

Projects
None yet
2 participants
@guitarrapc
Copy link
Contributor

guitarrapc commented Apr 12, 2019

Checklist

  • All new jobs, commands, executors, parameters have descriptions
  • Examples have been added for any significant new features
  • README has been updated, if necessary

Motivation, issues

I tried to use the aws-code-deploy/deploy-bundle orb, but strumbled because we need to provide more arguments. We are using iam with role_arn so that [default] is not working, and we need to pass --profile xxxxx for these. I've tried but AWS_PROFILE and AWS_DEFAULT_PROFILE not cover this scenario. I think this PR should do that, I already do in my repo and seems works fine. I'm happy to iterate if it needs more work:)

Should I add any example...?

arguments: '--profile abc123'

Description

  • add arguments parameter to create-application, create-deployment-group, push-bundle and deploy-bundle commands.
  • add arguments parameter to job deploy.
@iynere

This comment has been minimized.

Copy link
Contributor

iynere commented Apr 12, 2019

looks great ! @guitarrapc

sure, an example would be great :)

@iynere

iynere approved these changes Apr 12, 2019

@guitarrapc

This comment has been minimized.

Copy link
Contributor Author

guitarrapc commented Apr 12, 2019

thank you for review. ok, I will add example:)

@iynere iynere merged commit 35751f9 into CircleCI-Public:staging Apr 12, 2019

2 checks passed

ci/circleci: build Your tests passed on CircleCI!
Details
ci/circleci: lint Your tests passed on CircleCI!
Details

@guitarrapc guitarrapc deleted the guitarrapc:feat/aws_codedeploy_arguments branch Apr 12, 2019

@guitarrapc guitarrapc referenced this pull request Apr 12, 2019

Merged

fix: missing arguments on get-deployment #144

0 of 3 tasks complete
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.