Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

KUBECONFIG is the worst possible env var name for install-kubeconfig #33

Closed
ochronus opened this issue Nov 27, 2019 · 4 comments · Fixed by #34
Closed

KUBECONFIG is the worst possible env var name for install-kubeconfig #33

ochronus opened this issue Nov 27, 2019 · 4 comments · Fixed by #34
Labels
bug

Comments

@ochronus
Copy link

@ochronus ochronus commented Nov 27, 2019

Orb version

1.0.0

What happened

The install-kubeconfig section of the doc (and the source!) suggests KUBECONFIG as an env var to hold the base64 encoded kubernetes cluster config (also I need to look at the source to see that I need to base64 encode it). This causes all subsequent kubectl commands to fail as kubectl uses the same env variable to store the path to the config file - which is now a base64 encoded blob.

Expected behavior

The doc should suggest a different default name to hold the base64 encoded kubeconfig
The default for that variable should be different
The doc should state it needs to be base64 encoded

@ochronus ochronus added the bug label Nov 27, 2019
@lokst

This comment has been minimized.

Copy link
Contributor

@lokst lokst commented Nov 28, 2019

@ochronus Thank you for your feedback! I agree that the naming of the default environment variable for install-kubeconfig is not ideal at all. We'll fix that and also improve the documentation for the command.

@ochronus

This comment has been minimized.

Copy link
Author

@ochronus ochronus commented Nov 28, 2019

Sounds great, thanks for the quick reaction!
💕🙏

@lokst lokst closed this in #34 Dec 19, 2019
@lokst

This comment has been minimized.

Copy link
Contributor

@lokst lokst commented Dec 19, 2019

@ochronus This is now resolved in version 0.11.0 of the orb, which uses KUBECONFIG_DATA as the default env var name for install-kubeconfig 🙂

@ochronus

This comment has been minimized.

Copy link
Author

@ochronus ochronus commented Dec 19, 2019

Amazing news, thank you so much!!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.