Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: lock param on terraform plan (default to true) #106

Merged

Conversation

VincentPerez
Copy link
Contributor

Adding lock param on terraform plan (default to true)

I filed an issure here : #105

@henrahmagix
Copy link

@KyleTryon is it possible please to implement this PR? Currently, having terraform/plan run in every branch so we can review the output, makes any existing plan that's waiting to be applied stale, so it breaks our merging and applying flow. Being able to set -lock=false on PR branches would be extremely helpful ☺️

The changes seem to be correct to me =)

@KyleTryon
Copy link
Contributor

@KyleTryon is it possible please to implement this PR? Currently, having terraform/plan run in every branch so we can review the output, makes any existing plan that's waiting to be applied stale, so it breaks our merging and applying flow. Being able to set -lock=false on PR branches would be extremely helpful ☺️

The changes seem to be correct to me =)

Sorry. I am no longer a part of this organization.

@orb-publisher
Copy link

Your development orb has been published. It will expire in 30 days.
You can preview what this will look like on the CircleCI Orb Registry at the following link:
https://circleci.com/developer/orbs/orb/circleci/terraform?version=dev:daab6602bd753b523e83d07a13580628daab1486

@orb-publisher
Copy link

Your development orb has been published. It will expire in 30 days.
You can preview what this will look like on the CircleCI Orb Registry at the following link:
https://circleci.com/developer/orbs/orb/circleci/terraform?version=dev:8bb0ba44036b593990635ef08a2f629976ca04ed

@marboledacci marboledacci merged commit ef3478b into CircleCI-Public:master Sep 26, 2024
17 checks passed
@orb-publisher
Copy link

Your development orb has been published. It will expire in 30 days.
You can preview what this will look like on the CircleCI Orb Registry at the following link:
https://circleci.com/developer/orbs/orb/circleci/terraform?version=dev:ef3478be3aa4b1d7e13c08ed91b067ea3c05b549

@henrahmagix
Copy link

Thanks so much @marboledacci!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants