Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Navbar Enhanced #88

Merged
merged 2 commits into from Jul 29, 2021
Merged

Navbar Enhanced #88

merged 2 commits into from Jul 29, 2021

Conversation

vedant-jain03
Copy link
Member

Screenshot (42)

Enhancement:

  1. Remove Home Button
  2. Resize the logo to 70%
  3. Hover effect changed to green theme color background

fixes #87

@vedant-jain03
Copy link
Member Author

@nitin10s @ShreyaPrasad1209 @pavanjoshi914 please review

nitin10s
nitin10s requested changes Jul 23, 2021
View reviewed changes
Copy link
Member

@nitin10s nitin10s left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Contact button should be kept as previous only, just change the hover color to theme green

vedant-jain03
vedant-jain03 commented Jul 23, 2021
View reviewed changes
Copy link
Member Author

@vedant-jain03 vedant-jain03 left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Resolved @nitin10s

@nitin10s
Copy link
Member

Please update the screenshots as well

@vedant-jain03
Copy link
Member Author

Please update the screenshots as well

Screenshot (45)

@nitin10s Here is sample ss, hover on contact turn green as requested!

ShreyaPrasad1209
ShreyaPrasad1209 approved these changes Jul 24, 2021
View reviewed changes
Copy link
Member

@ShreyaPrasad1209 ShreyaPrasad1209 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, @nitin10s what do you think?

@vedant-jain03
Copy link
Member Author

@nitin10s Please review!

@nitin10s
Copy link
Member

@satu0king merge please

@ShreyaPrasad1209 ShreyaPrasad1209 merged commit 548c9ca into CircuitVerse:master Jul 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nitin10s nitin10s nitin10s approved these changes

@ShreyaPrasad1209 ShreyaPrasad1209 ShreyaPrasad1209 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Navbar Size
3 participants
@vedant-jain03 @nitin10s @ShreyaPrasad1209