Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixes: Simulator Navbar disappears at the end of tutorials guide #2360

Merged
merged 2 commits into from Jan 12, 2022

Conversation

vedant-jain03
Copy link
Member

Fixes #2348

Describe the changes you have made in this PR -

I have changed the styling of the issue button as it was overriding CSS of others, I convert its the position from absolute to fixed and also assigned it '!important' keyword on it's size

Screenshots of the changes (If any) -

  • Before
    Screenshot (58)
    Screenshot (59)

  • After
    Screenshot (56)
    Screenshot (57)

Note: Please check Allow edits from maintainers. if you would like us to assist in the PR.

@vedant-jain03
Copy link
Member Author

@pavanjoshi914 Please review my PR

@coveralls
Copy link

coveralls commented Jul 27, 2021

Coverage Status

Coverage remained the same at 84.751% when pulling 41df6ec on vedant-jain03:navbar_bug into 270ab87 on CircuitVerse:master.

@pavanjoshi914
Copy link
Member

please correct issues encountered by code climate

@codeclimate
Copy link

codeclimate bot commented Jul 28, 2021

Code Climate has analyzed commit 41df6ec and detected 0 issues on this pull request.

View more on Code Climate.

@vedant-jain03
Copy link
Member Author

@pavanjoshi914 Please review

@pavanjoshi914
Copy link
Member

LGTM

@tachyons

@tachyons
Copy link
Member

Please update PR with more meaningful title

@vedant-jain03 vedant-jain03 changed the title Bug Fixed in Tutorial Guide Fixes: Bug - Simulator Navbar disappears at the end of tutorials guide Aug 22, 2021
@vedant-jain03 vedant-jain03 changed the title Fixes: Bug - Simulator Navbar disappears at the end of tutorials guide Fixes: Simulator Navbar disappears at the end of tutorials guide Aug 22, 2021
@vedant-jain03 vedant-jain03 changed the title Fixes: Simulator Navbar disappears at the end of tutorials guide fixes: Simulator Navbar disappears at the end of tutorials guide Oct 2, 2021
@vedant-jain03
Copy link
Member Author

@tachyons Kindly Review

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bug - Simulator Navbar disappears at the end of tutorials guide
4 participants