Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

configure.ac: fix building of clamav milter #111

Closed
wants to merge 1 commit into from
Closed

configure.ac: fix building of clamav milter #111

wants to merge 1 commit into from

Conversation

bleve
Copy link
Contributor

@bleve bleve commented Oct 2, 2019

Signed-off-by: Tuomo Soini tis@foobar.fi

Signed-off-by: Tuomo Soini <tis@foobar.fi>
@micahsnyder
Copy link
Contributor

Thanks Tuomo! We'll test this out for inclusion into 0.102.1!

@prlw1
Copy link
Contributor

prlw1 commented Nov 1, 2019

Just wondering about the word "test" - the patch is clearly correct by inspection:
m4/reorganization/milter/enable.m4 defines the variable have_milter
m4/reorganization/milter/check.m4 uses the variable have_milter
configure.ac had better include enable.m4 before check.m4.

@micahsnyder
Copy link
Contributor

Hi @bleve @prlw1
We ended up fixing this in a slightly different way than this PR because the issue affected more than just milter.

The issue is fixed for dev/0.103 here: 4e585c8 and also in an identical commit in an internal branch for 0.102.1 that will be public once the security patch is released.

@micahsnyder micahsnyder closed this Nov 7, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants