Wait for the mockup server process to exit before moving on - #1513
Merged
Merged
Conversation
This fixes a race condition that triggers when the next server starts quicker than the previous one exits after signalling it asynchronously.
val-ms
approved these changes
May 30, 2025
val-ms
left a comment
val-ms
left a comment
Contributor
There was a problem hiding this comment.
Looks good in the linux/mac github workflows and on windows/linux/mac builds in jenkins.
I didn't attempt to reproduce the race condition, but the change makes sense and didn't cause any unexpected problems.
Thanks for the help @rma-x !
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes #1512, a race condition that triggers when the next server starts quicker than the previous one exits after signalling it asynchronously.