Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changed default config dir to <prefix>/etc/clamav #182

Conversation

micahsnyder
Copy link
Contributor

This resolves https://bugzilla.clamav.net/show_bug.cgi?id=12718

The default config directory on Linux/Unix systems will now be
${CMAKE_INSTALL_PREFIX}/etc/clamav
where it used to be:
${CMAKE_INSTALL_PREFIX}/etc

Note that most distributions will customize it to be:
/var/lib/clamav

@ragusaa ragusaa self-requested a review July 2, 2021 19:11
@micahsnyder micahsnyder force-pushed the CLAM-1509-config-subdirectory branch from 7d4ef56 to b660f17 Compare July 2, 2021 19:54
This resolves https://bugzilla.clamav.net/show_bug.cgi?id=12718

The default config directory on Linux/Unix systems will now be
   ${CMAKE_INSTALL_PREFIX}/etc/clamav
where it used to be:
   ${CMAKE_INSTALL_PREFIX}/etc

Note that most distributions will customize it to be:
   /var/lib/clamav
@micahsnyder micahsnyder force-pushed the CLAM-1509-config-subdirectory branch from b660f17 to c422b32 Compare July 18, 2021 00:29
@micahsnyder
Copy link
Contributor Author

This PR will requires changes to the jenkins test-framework (see PR) to use {TEST_PATH}/etc/clamav instead of {TEST_PATH/etc}. I ran into a some failures with that change on macOS because the command to reinstall the test-framework wasn't working properly. After changing it to force-reinstall, it seems to be working nicely. Since every PR after this will fail in Jenkins with the test-framework change without a rebase, I'm going to save it for last before the RC.

@micahsnyder micahsnyder added this to the 0.104 milestone Jul 19, 2021
@micahsnyder
Copy link
Contributor Author

I really wanted to do this but after extensive thought about this and discussing it with the mailing list, it feels like it will add extra confusion for many users. If you want to add a subdirectory in your clamav build for the config files, it's easy enough. Have a look at https://docs.clamav.net/manual/Installing/Installing-from-source-Unix.html#a-linux-distribution-style-build to see how.

@micahsnyder micahsnyder closed this Aug 5, 2021
@micahsnyder micahsnyder deleted the CLAM-1509-config-subdirectory branch August 5, 2021 18:41
@micahsnyder micahsnyder restored the CLAM-1509-config-subdirectory branch August 5, 2021 18:41
@micahsnyder micahsnyder deleted the CLAM-1509-config-subdirectory branch August 5, 2021 18:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants